From: Lukasz Luba <lukasz.luba@arm.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>, rui.zhang@intel.com
Cc: kai.heng.feng@canonical.com, srinivas.pandruvada@linux.intel.com,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Amit Kucheria <amitk@kernel.org>
Subject: Re: [PATCH 5/5] thermal/core: Remove notify ops
Date: Thu, 10 Dec 2020 14:37:16 +0000 [thread overview]
Message-ID: <9f6eb881-5be5-fa91-e087-0b899c0cf639@arm.com> (raw)
In-Reply-To: <20201210121514.25760-5-daniel.lezcano@linaro.org>
On 12/10/20 12:15 PM, Daniel Lezcano wrote:
> With the remove of the notify user in a previous patch, the ops is no
> longer needed, remove it.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> drivers/thermal/thermal_core.c | 3 ---
> include/linux/thermal.h | 2 --
> 2 files changed, 5 deletions(-)
>
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index cee0b31b5cd7..d7481fdf4e4c 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -407,9 +407,6 @@ static void handle_critical_trips(struct thermal_zone_device *tz,
>
> trace_thermal_zone_trip(tz, trip, trip_type);
>
> - if (tz->ops->notify)
> - tz->ops->notify(tz, trip, trip_type);
> -
> if (trip_type == THERMAL_TRIP_HOT && tz->ops->hot)
> tz->ops->hot(tz);
> else if (trip_type == THERMAL_TRIP_CRITICAL)
> diff --git a/include/linux/thermal.h b/include/linux/thermal.h
> index 125c8a4d52e6..7e051b4cf715 100644
> --- a/include/linux/thermal.h
> +++ b/include/linux/thermal.h
> @@ -77,8 +77,6 @@ struct thermal_zone_device_ops {
> int (*set_emul_temp) (struct thermal_zone_device *, int);
> int (*get_trend) (struct thermal_zone_device *, int,
> enum thermal_trend *);
> - int (*notify) (struct thermal_zone_device *, int,
> - enum thermal_trip_type);
> void (*hot)(struct thermal_zone_device *);
> void (*critical)(struct thermal_zone_device *);
> };
>
I couldn't find other users apart from those in patch 3/5 and 4/5.
I will leave to someone else to review those patches.
This patch looks good
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
next prev parent reply other threads:[~2020-12-10 14:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 12:15 [PATCH 1/5] thermal/core: Emit a warning if the thermal zone is updated without ops Daniel Lezcano
2020-12-10 12:15 ` [PATCH 2/5] thermal/core: Add critical and hot ops Daniel Lezcano
2020-12-10 12:44 ` Lukasz Luba
2020-12-10 13:37 ` Daniel Lezcano
2020-12-10 13:51 ` Lukasz Luba
2020-12-10 12:15 ` [PATCH 3/5] thermal/drivers/acpi: Use hot and critical ops Daniel Lezcano
2020-12-17 6:28 ` Daniel Lezcano
2020-12-17 11:38 ` Srinivas Pandruvada
2020-12-17 13:10 ` Daniel Lezcano
2020-12-10 12:15 ` [PATCH 4/5] thermal/drivers/rcar: Remove notification usage Daniel Lezcano
2020-12-10 16:10 ` Niklas Söderlund
2020-12-10 12:15 ` [PATCH 5/5] thermal/core: Remove notify ops Daniel Lezcano
2020-12-10 14:37 ` Lukasz Luba [this message]
2020-12-14 14:40 ` [thermal: thermal/next] thermal/core: Emit a warning if the thermal zone is updated without ops thermal-bot for Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f6eb881-5be5-fa91-e087-0b899c0cf639@arm.com \
--to=lukasz.luba@arm.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).