From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F215C19759 for ; Thu, 1 Aug 2019 23:49:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 517CC206A3 for ; Thu, 1 Aug 2019 23:49:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="obA8EwW+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390482AbfHAXtm (ORCPT ); Thu, 1 Aug 2019 19:49:42 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:4570 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733221AbfHAXtl (ORCPT ); Thu, 1 Aug 2019 19:49:41 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 01 Aug 2019 16:49:40 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 01 Aug 2019 16:49:38 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 01 Aug 2019 16:49:38 -0700 Received: from [10.110.103.107] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 1 Aug 2019 23:49:38 +0000 Subject: Re: [PATCH v7 07/20] clk: tegra: clk-periph: Add save and restore support From: Sowjanya Komatineni To: Dmitry Osipenko , , , , , , , , CC: , , , , , , , , , , , , , References: <1564532424-10449-1-git-send-email-skomatineni@nvidia.com> <1564532424-10449-8-git-send-email-skomatineni@nvidia.com>

<67cf6c13-688d-0305-61e2-c63c8e8b4729@nvidia.com> <550de191-f982-4544-6fbc-bf16dfeae2c6@nvidia.com>

<50bad1d3-df41-d1e5-a7c7-4be9c661ed14@nvidia.com> <62a5c6ed-21b1-8403-6fac-9c5d99b5a255@gmail.com> <85cd5100-467e-d08e-0ae5-ae57a6de5312@nvidia.com> <61652889-2e77-8f1e-9ed4-b7e525a40b10@nvidia.com> Message-ID: <9f6fc791-5c76-76d5-98fb-fd8facfd75d7@nvidia.com> Date: Thu, 1 Aug 2019 16:49:39 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <61652889-2e77-8f1e-9ed4-b7e525a40b10@nvidia.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1564703380; bh=eOm1bmspjUUEQ6f6iSgQG7jjTCSpSOMFim5pNksmTZg=; h=X-PGP-Universal:Subject:From:To:CC:References:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding: Content-Language; b=obA8EwW+NAGmVLKc++eLOFUW1RYK7Zyi7S8yzdpgY/TxkgDfEJDCxZSDnWdn3OnQc 7jd4Guc/LdHjiS8JctpPMjWbo91At9kpZDNJ8HJSWtqSz6vAzcHvsJrorv7dYCXbDJ Jx5bok/Mvc08ySS4VNCQJ8EmI61gnuEVxc/t3dLsLTmXrr134+bStjje8e/fT/LUKk Z6rt6ALKgUUXy7MHfAnsoj+ffNiaNPxiXaFPzv9Vmt/i8FyoEAMWliEoEaF1mHgkQb ZRCI0TeM6Ajm4oKNQ98fdjbEt+J/ToQaa0Xb/y8zApUIghHeQM2BeyenMhDNyekpcZ 5zfFPaIj8bp7Q== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/1/19 4:19 PM, Sowjanya Komatineni wrote: > > On 8/1/19 2:30 PM, Sowjanya Komatineni wrote: >> >> On 8/1/19 1:54 PM, Dmitry Osipenko wrote: >>> 01.08.2019 23:31, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>> On 8/1/19 1:17 PM, Dmitry Osipenko wrote: >>>>> 01.08.2019 22:42, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>>>> On 8/1/19 12:00 PM, Dmitry Osipenko wrote: >>>>>>> 01.08.2019 20:58, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1= =82: >>>>>>>> On 7/31/19 4:09 PM, Sowjanya Komatineni wrote: >>>>>>>>> On 7/31/19 3:44 AM, Dmitry Osipenko wrote: >>>>>>>>>> 31.07.2019 12:50, Dmitry Osipenko =D0=BF=D0=B8=D1=88=D0=B5=D1=82= : >>>>>>>>>>> 31.07.2019 3:20, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5= =D1=82: >>>>>>>>>>>> This patch implements save and restore context for peripheral >>>>>>>>>>>> fixed >>>>>>>>>>>> clock ops, peripheral gate clock ops, sdmmc mux clock ops, and >>>>>>>>>>>> peripheral clock ops. >>>>>>>>>>>> >>>>>>>>>>>> During system suspend, core power goes off and looses the=20 >>>>>>>>>>>> settings >>>>>>>>>>>> of the Tegra CAR controller registers. >>>>>>>>>>>> >>>>>>>>>>>> So during suspend entry clock and reset state of=20 >>>>>>>>>>>> peripherals is >>>>>>>>>>>> saved >>>>>>>>>>>> and on resume they are restored to have clocks back to same >>>>>>>>>>>> rate and >>>>>>>>>>>> state as before suspend. >>>>>>>>>>>> >>>>>>>>>>>> Acked-by: Thierry Reding >>>>>>>>>>>> Signed-off-by: Sowjanya Komatineni >>>>>>>>>>>> --- >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 drivers/clk/tegra/clk-periph-fixed.c = | 33 >>>>>>>>>>>> ++++++++++++++++++++++++++++++++ >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 drivers/clk/tegra/clk-periph-gate.c= =C2=A0 | 34 >>>>>>>>>>>> +++++++++++++++++++++++++++++++++ >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 drivers/clk/tegra/clk-periph.c=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 37 >>>>>>>>>>>> ++++++++++++++++++++++++++++++++++++ >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 drivers/clk/tegra/clk-sdmmc-mux.c=C2= =A0=C2=A0=C2=A0 | 28 >>>>>>>>>>>> +++++++++++++++++++++++++++ >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 drivers/clk/tegra/clk.h=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 6 ++++= ++ >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 5 files changed, 138 insertions(+) >>>>>>>>>>>> >>>>>>>>>>>> diff --git a/drivers/clk/tegra/clk-periph-fixed.c >>>>>>>>>>>> b/drivers/clk/tegra/clk-periph-fixed.c >>>>>>>>>>>> index c088e7a280df..21b24530fa00 100644 >>>>>>>>>>>> --- a/drivers/clk/tegra/clk-periph-fixed.c >>>>>>>>>>>> +++ b/drivers/clk/tegra/clk-periph-fixed.c >>>>>>>>>>>> @@ -60,11 +60,44 @@ tegra_clk_periph_fixed_recalc_rate(struct >>>>>>>>>>>> clk_hw *hw, >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return (unsig= ned long)rate; >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 } >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 +static int tegra_clk_periph_fixed_sa= ve_context(struct=20 >>>>>>>>>>>> clk_hw >>>>>>>>>>>> *hw) >>>>>>>>>>>> +{ >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 struct tegra_clk_periph_fixed *fixed =3D >>>>>>>>>>>> to_tegra_clk_periph_fixed(hw); >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 u32 mask =3D 1 << (fixed->num % 32); >>>>>>>>>>>> + >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 fixed->enb_ctx =3D readl_relaxed(fixed->ba= se + >>>>>>>>>>>> fixed->regs->enb_reg) & >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 mask; >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 fixed->rst_ctx =3D readl_relaxed(fixed->ba= se + >>>>>>>>>>>> fixed->regs->rst_reg) & >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 mask; >>>>>>>>>>>> + >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 return 0; >>>>>>>>>>>> +} >>>>>>>>>>>> + >>>>>>>>>>>> +static void tegra_clk_periph_fixed_restore_context(struct=20 >>>>>>>>>>>> clk_hw >>>>>>>>>>>> *hw) >>>>>>>>>>>> +{ >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 struct tegra_clk_periph_fixed *fixed =3D >>>>>>>>>>>> to_tegra_clk_periph_fixed(hw); >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 u32 mask =3D 1 << (fixed->num % 32); >>>>>>>>>>>> + >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 if (fixed->enb_ctx) >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 writel_relaxed(mas= k, fixed->base + >>>>>>>>>>>> fixed->regs->enb_set_reg); >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 else >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 writel_relaxed(mas= k, fixed->base + >>>>>>>>>>>> fixed->regs->enb_clr_reg); >>>>>>>>>>>> + >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 udelay(2); >>>>>>>>>>>> + >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 if (!fixed->rst_ctx) { >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 udelay(5); /* rese= t propogation delay */ >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 writel_relaxed(mas= k, fixed->base +=20 >>>>>>>>>>>> fixed->regs->rst_reg); >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 } >>>>>>>>>>>> +} >>>>>>>>>>>> + >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 static const struct clk_ops tegra_clk= _periph_fixed_ops=20 >>>>>>>>>>>> =3D { >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .is_enabled = =3D tegra_clk_periph_fixed_is_enabled, >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .enable =3D t= egra_clk_periph_fixed_enable, >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .disable =3D = tegra_clk_periph_fixed_disable, >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .recalc_rate = =3D tegra_clk_periph_fixed_recalc_rate, >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 .save_context =3D tegra_clk_periph_fixed_s= ave_context, >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 .restore_context =3D=20 >>>>>>>>>>>> tegra_clk_periph_fixed_restore_context, >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 }; >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0 struct clk *tegra_clk_register= _periph_fixed(const char >>>>>>>>>>>> *name, >>>>>>>>>>>> diff --git a/drivers/clk/tegra/clk-periph-gate.c >>>>>>>>>>>> b/drivers/clk/tegra/clk-periph-gate.c >>>>>>>>>>>> index 4b31beefc9fc..6ba5b08e0787 100644 >>>>>>>>>>>> --- a/drivers/clk/tegra/clk-periph-gate.c >>>>>>>>>>>> +++ b/drivers/clk/tegra/clk-periph-gate.c >>>>>>>>>>>> @@ -25,6 +25,8 @@ static DEFINE_SPINLOCK(periph_ref_lock); >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0 #define read_rst(gate) \ >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 readl_relaxed= (gate->clk_base + (gate->regs->rst_reg)) >>>>>>>>>>>> +#define write_rst_set(val, gate) \ >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 writel_relaxed(val, gate->clk_base + >>>>>>>>>>>> (gate->regs->rst_set_reg)) >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 #define write_rst_clr(val, gate) \ >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 writel_relaxe= d(val, gate->clk_base + >>>>>>>>>>>> (gate->regs->rst_clr_reg)) >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 @@ -110,10 +112,42 @@ static void=20 >>>>>>>>>>>> clk_periph_disable(struct >>>>>>>>>>>> clk_hw *hw) >>>>>>>>>>>> spin_unlock_irqrestore(&periph_ref_lock, flags); >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 } >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 +static int clk_periph_gate_save_cont= ext(struct clk_hw=20 >>>>>>>>>>>> *hw) >>>>>>>>>>>> +{ >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 struct tegra_clk_periph_gate *gate =3D=20 >>>>>>>>>>>> to_clk_periph_gate(hw); >>>>>>>>>>>> + >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 gate->clk_state_ctx =3D read_enb(gate) & >>>>>>>>>>>> periph_clk_to_bit(gate); >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 gate->rst_state_ctx =3D read_rst(gate) & >>>>>>>>>>>> periph_clk_to_bit(gate); >>>>>>>>>>>> + >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 return 0; >>>>>>>>>>>> +} >>>>>>>>>>>> + >>>>>>>>>>>> +static void clk_periph_gate_restore_context(struct clk_hw=20 >>>>>>>>>>>> *hw) >>>>>>>>>>>> +{ >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 struct tegra_clk_periph_gate *gate =3D=20 >>>>>>>>>>>> to_clk_periph_gate(hw); >>>>>>>>>>>> + >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 if (gate->clk_state_ctx) >>>>>>>>>>>> + write_enb_set(periph_clk_to_bit(gate), gate); >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 else >>>>>>>>>>>> + write_enb_clr(periph_clk_to_bit(gate), gate); >>>>>>>>>>>> + >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 udelay(5); >>>>>>>>>>>> + >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 if (!(gate->flags & TEGRA_PERIPH_NO_RESET)= && >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 !(gate->flags & TE= GRA_PERIPH_MANUAL_RESET)) { >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (gate->rst_stat= e_ctx) >>>>>>>>>>>> + write_rst_set(periph_clk_to_bit(gate), gate); >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 else >>>>>>>>>>>> + write_rst_clr(periph_clk_to_bit(gate), gate); >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 } >>>>>>>>>>>> +} >>>>>>>>>>>> + >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 const struct clk_ops tegra_clk_periph= _gate_ops =3D { >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .is_enabled = =3D clk_periph_is_enabled, >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .enable =3D c= lk_periph_enable, >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .disable =3D = clk_periph_disable, >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 .save_context =3D clk_periph_gate_save_con= text, >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 .restore_context =3D clk_periph_gate_resto= re_context, >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 }; >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0 struct clk *tegra_clk_register= _periph_gate(const=20 >>>>>>>>>>>> char *name, >>>>>>>>>>>> diff --git a/drivers/clk/tegra/clk-periph.c >>>>>>>>>>>> b/drivers/clk/tegra/clk-periph.c >>>>>>>>>>>> index 58437da25156..06fb62955768 100644 >>>>>>>>>>>> --- a/drivers/clk/tegra/clk-periph.c >>>>>>>>>>>> +++ b/drivers/clk/tegra/clk-periph.c >>>>>>>>>>>> @@ -99,6 +99,37 @@ static void clk_periph_disable(struct=20 >>>>>>>>>>>> clk_hw >>>>>>>>>>>> *hw) >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 gate_ops->dis= able(gate_hw); >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 } >>>>>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 +static int clk_periph_save_context(s= truct clk_hw *hw) >>>>>>>>>>>> +{ >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 struct tegra_clk_periph *periph =3D to_clk= _periph(hw); >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 const struct clk_ops *gate_ops =3D periph-= >gate_ops; >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 struct clk_hw *gate_hw =3D &periph->gate.h= w; >>>>>>>>>>>> + >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 if (!(periph->gate.flags & TEGRA_PERIPH_NO= _GATE)) >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 gate_ops->save_con= text(gate_hw); >>>>>>>>>>>> + >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 periph->parent_ctx =3D clk_periph_get_pare= nt(hw); >>>>>>>>>>>> + >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 return 0; >>>>>>>>>>>> +} >>>>>>>>>>>> + >>>>>>>>>>>> +static void clk_periph_restore_context(struct clk_hw *hw) >>>>>>>>>>>> +{ >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 struct tegra_clk_periph *periph =3D to_clk= _periph(hw); >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 const struct clk_ops *gate_ops =3D periph-= >gate_ops; >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 struct clk_hw *gate_hw =3D &periph->gate.h= w; >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 const struct clk_ops *div_ops =3D periph->= div_ops; >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 struct clk_hw *div_hw =3D &periph->divider= .hw; >>>>>>>>>>>> + >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 clk_periph_set_parent(hw, periph->parent_c= tx); >>>>>>>>>>>> + >>>>>>>>>>>> +=C2=A0=C2=A0=C2=A0 if (!(periph->gate.flags & TEGRA_PERIPH_NO= _DIV)) >>>>>>>>>>>> + div_ops->restore_context(div_hw); >>>>>>>>>>> Could you please point to where the divider's save_context() >>>>>>>>>>> happens? >>>>>>>>>>> Because I can't see it. >>>>>>>>>> Ah, I now see that there is no need to save the dividers context >>>>>>>>>> because >>>>>>>>>> clk itself has enough info that is needed for the context's >>>>>>>>>> restoring >>>>>>>>>> (like I pointed in the review to v6). >>>>>>>>>> >>>>>>>>>> Looks like you could also implement a new=20 >>>>>>>>>> clk_hw_get_parent_index() >>>>>>>>>> generic helper to get the index instead of storing it manually. >>>>>>>>> clk_periph_get_parent basically invokes existing clk_mux_ops >>>>>>>>> get_parent() which is then saved in tegra_clk_periph. >>>>>>>>> >>>>>>>>> All existing drivers are using directly get_parent() from clk_mux >>>>>>>>> which actually gets index from the register read. >>>>>>>>> >>>>>>>>> To have this more generic w.r.t save/restore context point of=20 >>>>>>>>> view, >>>>>>>>> probably instead of implementing new get_parent_index helper,=20 >>>>>>>>> I think >>>>>>>>> its better to implement save_context and restore_context to >>>>>>>>> clk_mux_ops along with creating parent_index field into=20 >>>>>>>>> clk_mux to >>>>>>>>> cache index during set_parent. >>>>>>>>> >>>>>>>>> So we just need to invoke mux_ops save_context and=20 >>>>>>>>> restore_context. >>>>>>>>> >>>>>>>> I hope its ok to add save/restore context to clk_mux_ops to be=20 >>>>>>>> more >>>>>>>> generic w.r.t save/restore context rather than get_parent_index=20 >>>>>>>> API. >>>>>>>> Please confirm if you agree. >>>>>>> Sounds like a good idea. I see that there is a 'restoring'=20 >>>>>>> helper for >>>>>>> the generic clk_gate, seems something similar could be done for the >>>>>>> clk_mux. And looks like anyway you'll need to associate the parent >>>>>>> clock >>>>>>> with the hw index in order to restore the muxing. >>>>>> by 'restoring' helper for generic clk_gate, are you referring to >>>>>> clk_gate_restore_context API? >>>>> Yes. >>>>> >>>>>> clk_gate_restore_context is API that's any clk drivers can use for >>>>>> clk_gate operation restore for custom gate clk_ops. >>>>>> >>>>>> But clk-periph is directly using generic clk_mux ops from clk_mux=20 >>>>>> so I >>>>>> think we should add .restore_context to clk_mux_ops and then during >>>>>> clk-periph restore need to invoke mux_ops->restore_context. >>>>> I'm not sure whether it will be good for every driver that uses=20 >>>>> generic >>>>> clk_mux ops. Should be more flexible to have a generic helper=20 >>>>> function >>>>> that any driver could use in order to restore the clock's parent. >>>>> >>>>> The clk-periph restoring also includes case of combining divider and >>>>> parent restoring, so generic helper could be useful in that case=20 >>>>> as well. >>>>> >>>>> It also looks like you could actually use the=20 >>>>> clk_gate_restore_context() >>>>> instead of manually saving the clock's enable-state, couldn't you? >>>> ok for clk_mux, can add generic clk_mux_restore_context API rather=20 >>>> than >>>> using restore_context in clk_ops and will invoke that during=20 >>>> clk_periph >>>> restore. >>>> digging thru looks like for clk_periph source restore instead of=20 clk_mux_restore_context, i can directly do clk_hw_get_parent and=20 clk_set_parent with mux_hw as they invoke mux_ops get/set parent anyway.=20 Will do this for periph clk mux >>>> >>>> Reg clk_gate, looks like we cant use generic clk_gate_restore_context >>>> for clk-periph as it calls enable/disable callbacks and >>>> clk_periph_enable/disable in clk-periph-gate also updated refcnt and >>>> depending on that actual enable/disable is set. >>>> >>>> During suspend, peripherals that are already enabled have their=20 >>>> refcnt > >>>> 1, so they dont go thru enable/disable on restore if we use same >>>> enable/disable callback. >>> Looks like you could just decrement the gate's enable_refcnt on >>> save_context, wouldn't that work? >>> > gate->enable_refcnt is within clk-periph-gate which gets updated when=20 > enable/disable callbacks get execute thru clk_core_enable/disable. > But actual enable_count used in clk_gate_restore_context is the one=20 > which gets updated with in the clk core enable/disable functions which=20 > invokes these callbacks. Depending on this enable_count in clk core it=20 > invokes enable/disable. > > So, this will cause mismatch if we handle refcnt during save/restore=20 > of tegra_clk_periph_gate_ops and also enable/disable thru this=20 > clk_gate_restore_context is based on enable_count from clk core. > >>>> Also to align exact reset state along with CLK (like for case where=20 >>>> CLK >>>> is enabled but peripheral might be in reset state), implemented >>>> save/restore in tegra specific tegra_clk_periph_gate_ops >>> I'm wondering whether instead of saving/restoring reset-state of every >>> clock, you could simply save/restore the whole RST_DEV_x_SET register. >>> Couldn't you? >> Thats what I was doing in first version of patch. But later as we=20 >> moved to use clk_save_context and clk_restore_context, peripheral=20 >> clk_hw RST & CLK enables happen thru its corresponding save/restore=20 >> after source restore > > > Also, to align both CLK & RST to the exact state of register, doing=20 > save/restore in tegra_clk_periph_gate_ops and invoking this after=20 > source restore for peripheral clock, seems cleaner to avoid any=20 > misconfiguration b/w rst & clk settings. >