From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751582AbdLDAYj (ORCPT <rfc822;w@1wt.eu>);
        Sun, 3 Dec 2017 19:24:39 -0500
Received: from mail-pf0-f196.google.com ([209.85.192.196]:33504 "EHLO
        mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750988AbdLDAYg (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 3 Dec 2017 19:24:36 -0500
X-Google-Smtp-Source: AGs4zMa7cP5HAfuhgXBOBbp334Ac2q9s8i3p1vbIzYIoiEZQXCMLYpFjL2sRTszBusuEVVeVIASaqw==
Subject: Re: possible deadlock in blk_trace_remove
To: Eric Biggers <ebiggers3@gmail.com>,
        syzbot 
        <bot+583353673e394aa41e5fb68ddc8b8d9d5c8d576f@syzkaller.appspotmail.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        mingo@redhat.com, rostedt@goodmis.org, syzkaller-bugs@googlegroups.com
References: <001a1141f8dc4440a9055e53896e@google.com>
 <20171203202434.GD844@zzz.localdomain>
From: Jens Axboe <axboe@kernel.dk>
Message-ID: <9f7ab661-7d57-3e84-769c-6d103557f342@kernel.dk>
Date: Sun, 3 Dec 2017 17:24:32 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <20171203202434.GD844@zzz.localdomain>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/03/2017 01:24 PM, Eric Biggers wrote:
> On Sun, Nov 19, 2017 at 02:36:01AM -0800, syzbot wrote:
>> Hello,
>>
>> syzkaller hit the following crash on
>> d9e0e63d9a6f88440eb201e1491fcf730272c706
>> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master
>> compiler: gcc (GCC) 7.1.1 20170620
>> .config is attached
>> Raw console output is attached.
>>
>> Unfortunately, I don't have any reproducer for this bug yet.
>>
>>
>> Use struct sctp_sack_info instead
>>
>> ============================================
>> WARNING: possible recursive locking detected
>> 4.14.0-rc8-next-20171110+ #40 Not tainted
>> --------------------------------------------
>> syz-executor6/21462 is trying to acquire lock:
>>  (&q->blk_trace_mutex){+.+.}, at: [<ffffffff81760261>]
>> blk_trace_remove+0x21/0x40 kernel/trace/blktrace.c:373
>>
>> but task is already holding lock:
>>  (&q->blk_trace_mutex){+.+.}, at: [<ffffffff81763b38>]
>> blk_trace_setup+0x38/0x70 kernel/trace/blktrace.c:606
>>
>> other info that might help us debug this:
>>  Possible unsafe locking scenario:
> 
> #syz fix: blktrace: fix trace mutex deadlock

This is fixed in current -git.

-- 
Jens Axboe