From: <Razvan.Stefanescu@microchip.com>
To: <ioana.ciornei@nxp.com>, <gregkh@linuxfoundation.org>,
<linux-kernel@vger.kernel.org>
Cc: <joe@perches.com>, <andrew@lunn.ch>, <ruxandra.radulescu@nxp.com>
Subject: Re: [PATCH v2 10/10] staging: fsl-dpaa2/ethsw: do not force user to bring interface down
Date: Tue, 13 Aug 2019 09:38:01 +0000 [thread overview]
Message-ID: <9f932adb-fb6d-2973-f5af-6ba9a83be454@microchip.com> (raw)
In-Reply-To: <1565686479-32577-11-git-send-email-ioana.ciornei@nxp.com>
On 13/08/2019 11:54, Ioana Ciornei wrote:
> Link settings can be changed only when the interface is down. Disable
> and re-enable the interface, if necessary, behind the scenes so that we do
> not force users to an if down/up sequence.
>
> Reported-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> ---
> Changes in v2:
> - added Reported-by tag
>
> drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c | 32 ++++++++++++++++++-------
> 1 file changed, 23 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c
> index 0f9f8345e534..99d658fefa14 100644
> --- a/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c
> +++ b/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c
> @@ -88,16 +88,21 @@ static void ethsw_get_drvinfo(struct net_device *netdev,
> const struct ethtool_link_ksettings *link_ksettings)
> {
> struct ethsw_port_priv *port_priv = netdev_priv(netdev);
> + struct ethsw_core *ethsw = port_priv->ethsw_data;
> struct dpsw_link_cfg cfg = {0};
> - int err = 0;
> -
> - /* Due to a temporary MC limitation, the DPSW port must be down
> - * in order to be able to change link settings. Taking steps to let
> - * the user know that.
> - */
> - if (netif_running(netdev)) {
> - netdev_info(netdev, "Sorry, interface must be brought down first.\n");
> - return -EACCES;
> + bool if_running;
> + int err = 0, ret;
> +
> + /* Interface needs to be down to change link settings */
> + if_running = netif_running(netdev);
> + if (if_running) {
> + err = dpsw_if_disable(ethsw->mc_io, 0,
> + ethsw->dpsw_handle,
> + port_priv->idx);
> + if (err) {
> + netdev_err(netdev, "dpsw_if_disable err %d\n", err);
> + return err;
> + }
> }
>
> cfg.rate = link_ksettings->base.speed;
> @@ -115,6 +120,15 @@ static void ethsw_get_drvinfo(struct net_device *netdev,
> port_priv->idx,
> &cfg);
>
> + if (if_running) {
> + ret = dpsw_if_enable(ethsw->mc_io, 0,
> + ethsw->dpsw_handle,
> + port_priv->idx);
> + if (ret) {
> + return ret;
> + netdev_err(netdev, "dpsw_if_enable err %d\n", ret);
Hello,
These last two lines need to be swapped.
Best regards,
Razvan
next prev parent reply other threads:[~2019-08-13 9:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 8:54 [PATCH v2 00/10] staging: fsl-dpaa2/ethsw: code cleanup Ioana Ciornei
2019-08-13 8:54 ` [PATCH v2 01/10] staging: fsl-dpaa2/ethsw: remove IGMP default address Ioana Ciornei
2019-08-13 8:54 ` [PATCH v2 02/10] staging: fsl-dpaa2/ethsw: enable switch ports only on dev_open Ioana Ciornei
2019-08-13 8:54 ` [PATCH v2 03/10] staging: fsl-dpaa2/ethsw: add line terminator to all formats Ioana Ciornei
2019-08-13 8:54 ` [PATCH v2 04/10] staging: fsl-dpaa2/ethsw: remove debug message Ioana Ciornei
2019-08-13 8:54 ` [PATCH v2 05/10] staging: fsl-dpaa2/ethsw: use bool when encoding learning/flooding state Ioana Ciornei
2019-08-13 8:54 ` [PATCH v2 06/10] staging: fsl-dpaa2/ethsw: remove unnecessary memset Ioana Ciornei
2019-08-13 8:54 ` [PATCH v2 07/10] staging: fsl-dpaa2/ethsw: remove redundant VLAN check Ioana Ciornei
2019-08-13 8:54 ` [PATCH v2 08/10] staging: fsl-dpaa2/ethsw: reword error message Ioana Ciornei
2019-08-13 8:54 ` [PATCH v2 09/10] staging: fsl-dpaa2/ethsw: register_netdev only when ready Ioana Ciornei
2019-08-13 8:54 ` [PATCH v2 10/10] staging: fsl-dpaa2/ethsw: do not force user to bring interface down Ioana Ciornei
2019-08-13 9:38 ` Razvan.Stefanescu [this message]
2019-08-13 9:43 ` Ioana Ciornei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f932adb-fb6d-2973-f5af-6ba9a83be454@microchip.com \
--to=razvan.stefanescu@microchip.com \
--cc=andrew@lunn.ch \
--cc=gregkh@linuxfoundation.org \
--cc=ioana.ciornei@nxp.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ruxandra.radulescu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).