linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: Du Changbin <changbin.du@gmail.com>,
	jan.kiszka@siemens.com, kbingham@kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts/gdb: fix lx-version for gdb 7.3-
Date: Wed, 17 Oct 2018 13:31:26 +0100	[thread overview]
Message-ID: <9fb27240-b0d5-f49f-4dfa-0d8aa25f6cef@ideasonboard.com> (raw)
In-Reply-To: <20181017023652.6867-1-changbin.du@gmail.com>

Hi Du,

On 17/10/18 03:36, Du Changbin wrote:
> For gdb version less than 7.3, lx-version only one character.
> (gdb) lx-version
> L(gdb)
> 
> This can be fixed by casting 'linux_banner' as (char *).
> (gdb) lx-version
> Linux version 4.19.0-rc1+ (changbin@acer) (gcc version 7.3.0 (Ubuntu 7.3.0-16ubuntu3)) #21 SMP Sat Sep 1 21:43:30 CST 2018
> 
> gdb 7.4 seems to be no such issue.
> 
> Signed-off-by: Du Changbin <changbin.du@gmail.com>
> ---
>  scripts/gdb/linux/proc.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/gdb/linux/proc.py b/scripts/gdb/linux/proc.py
> index 086d27223c0c..0aebd7565b03 100644
> --- a/scripts/gdb/linux/proc.py
> +++ b/scripts/gdb/linux/proc.py
> @@ -41,7 +41,7 @@ class LxVersion(gdb.Command):
>  
>      def invoke(self, arg, from_tty):
>          # linux_banner should contain a newline
> -        gdb.write(gdb.parse_and_eval("linux_banner").string())
> +        gdb.write(gdb.parse_and_eval("(char *)linux_banner").string())


Interesting - this is an issue I reported to the GDB team after I'd
tried to dig into the fault.

  https://sourceware.org/bugzilla/show_bug.cgi?id=20077

the parse_and_eval finds a string length of 0, but then later in the GBD
parsing it gets incremented to 1, hence the single char. I guess it's
some failure in GDB determining the type of the pointer.

However, from reading the bugzilla entry and from what I recall - it
only occurred if you had done a backtrace before calling lx-version.

Did you discover that it would always return only the single character
in your testing ? Even if it was the first command executed?

My worry is - that if this fixes lx-version - do we also need to
manually cast lx-cmdline as well ? (I never saw the issue occur on that
cmd).

I think considering the age of the bugzilla at GDB, and the lack of any
GDB level fix or understanding - we should certainly apply this fix here
- and probably include it in the stable trees too.


With the title fix as highlighted by Jan,

Reviewed-by: Kieran Bingham <kbingham@kernel.org>

Would you be able to test the issue with the lx-cmdline command as well
please? And if it is suffering the same issue - perhaps you could either
submit a second patch to update that entry - or respin this one to
include both?



>  
>  LxVersion()
>  
> 


-- 
Regards
--
Kieran

      parent reply	other threads:[~2018-10-17 12:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-17  2:36 [PATCH] scripts/gdb: fix lx-version for gdb 7.3- Du Changbin
2018-10-17  6:56 ` Jan Kiszka
2018-10-17 13:39   ` Changbin Du
2018-10-17 12:31 ` Kieran Bingham [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9fb27240-b0d5-f49f-4dfa-0d8aa25f6cef@ideasonboard.com \
    --to=kieran.bingham@ideasonboard.com \
    --cc=changbin.du@gmail.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kbingham@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).