From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030403AbcJaUWv (ORCPT ); Mon, 31 Oct 2016 16:22:51 -0400 Received: from mail-yw0-f171.google.com ([209.85.161.171]:34898 "EHLO mail-yw0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S945995AbcJaUWs (ORCPT ); Mon, 31 Oct 2016 16:22:48 -0400 Subject: Re: [PATCH 4/7] lightnvm: drop reserve and release LUN callbacks To: =?UTF-8?Q?Matias_Bj=c3=b8rling?= , =?UTF-8?Q?Javier_Gonz=c3=a1lez?= References: <1477591299-26504-1-git-send-email-javier@cnexlabs.com> <1477591299-26504-5-git-send-email-javier@cnexlabs.com> Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Javier_Gonz=c3=a1lez?= , =?UTF-8?Q?Javier_Gonz=c3=a1lez?= From: Jens Axboe Message-ID: <9fc12698-de1b-b535-f8c4-d283a29a6099@kernel.dk> Date: Mon, 31 Oct 2016 14:22:45 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/31/2016 07:08 AM, Matias Bjørling wrote: > On 10/27/2016 08:01 PM, Javier González wrote: >> From: Javier González >> >> On target initialization, targets use callbacks to the media manager to >> configure the LUNs they use. In order to simplify the flow, drop this >> callbacks and manage everything internally on the media manager. >> >> By making use of the newly introduce LUN management structure, the media >> manager knows which target exclusively owns each target and can >> therefore allocate and free all the necessary structures before >> initializing the target. Not exclusively owned LUNs belong to the media >> manager in any case. >> >> Adapt rrpc to not use the reserve_lun/release_lun callback functions. >> >> Signed-off-by: Javier González >> --- >> drivers/lightnvm/gennvm.c | 68 ++++++++++++++++++++++++++++++++++++----------- >> drivers/lightnvm/rrpc.c | 12 +-------- >> include/linux/lightnvm.h | 5 +--- >> 3 files changed, 55 insertions(+), 30 deletions(-) >> >> diff --git a/drivers/lightnvm/gennvm.c b/drivers/lightnvm/gennvm.c >> index 8bff725..a340685 100644 >> --- a/drivers/lightnvm/gennvm.c >> +++ b/drivers/lightnvm/gennvm.c >> @@ -35,6 +35,50 @@ static const struct block_device_operations gen_fops = { >> .owner = THIS_MODULE, >> }; >> >> +static int gen_reserve_luns(struct nvm_dev *dev, int lun_begin, int lun_end, >> + struct nvm_target *t) >> +{ >> + struct gen_dev *gn = dev->mp; >> + struct gen_lun *lun; >> + int i; >> + >> + for (i = lun_begin; i <= lun_end; i++) { >> + if (test_and_set_bit(i, dev->lun_map)) { >> + pr_err("gennvm: lun %d is already allocated\n", i); >> + goto fail; >> + } >> + >> + lun = &gn->luns[i]; >> + lun->tgt = t; >> + lun->vlun.priv = lun->mgmt; >> + } >> + >> + return 0; >> +fail: >> + while (--i > lun_begin) >> + clear_bit(i, dev->lun_map); >> + >> + return 1; > > return -EINVAL; -EBUSY? > Lad os lige snakke lidt om dette her senere også :) And probably keep the public emails in English :-) -- Jens Axboe