From: Joe Perches <joe@perches.com>
To: SeongJae Park <sjpark@amazon.com>
Cc: akpm@linux-foundation.org, apw@canonical.com,
colin.king@canonical.com, sj38.park@gmail.com,
linux-kernel@vger.kernel.org, SeongJae Park <sjpark@amazon.de>
Subject: Re: Re: [PATCH v3 1/2] checkpatch: support deprecated terms checking
Date: Wed, 10 Jun 2020 01:45:41 -0700 [thread overview]
Message-ID: <9fcbcf91beb884ef8eac64471fe769edebce660c.camel@perches.com> (raw)
In-Reply-To: <20200610080102.17456-1-sjpark@amazon.com>
On Wed, 2020-06-10 at 10:01 +0200, SeongJae Park wrote:
> On Wed, 10 Jun 2020 00:13:42 -0700 Joe Perches <joe@perches.com> wrote:
[]
> > This is a direct copy of the spelling dictionary
> > loading code, so maybe these could be consolidated.
>
> Agreed, how about below one?
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 524df88f9364..226f24e1f1f3 100755
[]
> +sub read_word_corrections {
> + my ($file) = @_;
> + my $suspects;
> + my %fixes;
Right.
But I think this should take a hash reference
as the second argument so the complete hash
isn't created and returned.
[]
> +# Load deprecated terms and build regular expression list.
> +my %deprecated_terms_fix = read_word_corrections($deprecated_terms_file);
So this might be something like:
my %deprecated_terms;
read_word_corrections($deprecated_terms_file, \%deprecated_terms);
etc...
next prev parent reply other threads:[~2020-06-10 8:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 6:52 [PATCH v3 0/2] Recommend blocklist/allowlist instead of blacklist/whitelist SeongJae Park
2020-06-10 6:52 ` [PATCH v3 1/2] checkpatch: support deprecated terms checking SeongJae Park
2020-06-10 7:13 ` Joe Perches
2020-06-10 8:01 ` SeongJae Park
2020-06-10 8:45 ` Joe Perches [this message]
2020-06-10 9:09 ` SeongJae Park
2020-06-10 6:52 ` [PATCH v3 2/2] scripts/deprecated_terms: Recommend blocklist/allowlist instead of blacklist/whitelist SeongJae Park
2020-06-10 13:54 ` SeongJae Park
2020-06-10 7:06 ` [PATCH v3 0/2] " Joe Perches
2020-06-14 21:15 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fcbcf91beb884ef8eac64471fe769edebce660c.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=colin.king@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sj38.park@gmail.com \
--cc=sjpark@amazon.com \
--cc=sjpark@amazon.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).