From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3121DC433EF for ; Fri, 19 Nov 2021 07:50:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 14ED461B39 for ; Fri, 19 Nov 2021 07:50:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232653AbhKSHxK (ORCPT ); Fri, 19 Nov 2021 02:53:10 -0500 Received: from mail-ed1-f41.google.com ([209.85.208.41]:44733 "EHLO mail-ed1-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbhKSHxJ (ORCPT ); Fri, 19 Nov 2021 02:53:09 -0500 Received: by mail-ed1-f41.google.com with SMTP id l25so22516254eda.11; Thu, 18 Nov 2021 23:50:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=V6h6CbHA6xauuifg0Lvf0Q7kGutuZTAYH4tez+KhU+Y=; b=qusjN5gW6lLhO3CEGyzdO/48knZb3+XdCnvmDiGEIMMBbjmAC8Fw/9tyGUN4VGItDB H1wWpbM+1QtjvduIRIDXrHAZFXcGSk8c78pSCsUbrxFYHa2DvZm81jOIYIhPD1kIplLN gP/wi3T0lALINfcuCnwYFgeZLK6W9w2QG6UPDgRrR9ylGVbknWDV/Jb+T5BUdhdB1wnJ ap4VZkK20Ca5IEe7gQJzZxiPMgSV2hTeD5Ueke5O0wWin+czMM+s8jjoS+ZqGXBag5Xl f51Y+2zbJuD1EJi45ohJMNvrvcesdrpmnSbQq691OjBy5yNZQ3ddkE0GVKsyp1ETq1B2 GD9g== X-Gm-Message-State: AOAM531Ed44yrbl3b4lUAKwEUCCsyh2jw0VmZNk4Ptueo+eSXTkycja+ GiddBcVzBqYZPQazz6LRzg8= X-Google-Smtp-Source: ABdhPJzxrDlND5Enpr5kn5K7A5GVLapxXrlQQ/6doRb2qKQI5xSmgXArFRGDgiEzTB9LGgK+jDNGkQ== X-Received: by 2002:a50:bf01:: with SMTP id f1mr21065220edk.102.1637308206961; Thu, 18 Nov 2021 23:50:06 -0800 (PST) Received: from ?IPV6:2a0b:e7c0:0:107::70f? ([2a0b:e7c0:0:107::70f]) by smtp.gmail.com with ESMTPSA id hz15sm842135ejc.63.2021.11.18.23.50.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Nov 2021 23:50:06 -0800 (PST) Message-ID: <9fdb2bf1-de52-1b9d-4783-c61ce39e8f51@kernel.org> Date: Fri, 19 Nov 2021 08:50:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH 5.15 808/917] drm: fb_helper: improve CONFIG_FB dependency Content-Language: en-US To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, "Acked-by: Jani Nikula" , Javier Martinez Canillas , Arnd Bergmann , Daniel Vetter , Sasha Levin References: <20211115165428.722074685@linuxfoundation.org> <20211115165456.391822721@linuxfoundation.org> From: Jiri Slaby In-Reply-To: <20211115165456.391822721@linuxfoundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15. 11. 21, 18:05, Greg Kroah-Hartman wrote: > From: Arnd Bergmann > > [ Upstream commit 9d6366e743f37d36ef69347924ead7bcc596076e ] Hi, this breaks build on openSUSE's armv7hl config: $ wget -O .config https://raw.githubusercontent.com/openSUSE/kernel-source/stable/config/armv7hl/default $ make -j168 CROSS_COMPILE=arm-suse-linux-gnueabi- ARCH=arm vmlinux ... LD .tmp_vmlinux.btf arm-suse-linux-gnueabi-ld: drivers/gpu/drm/panel/panel-simple.o: in function `panel_simple_probe': drivers/gpu/drm/panel/panel-simple.c:803: undefined reference to `drm_panel_dp_aux_backlight' $ grep -E 'CONFIG_(DRM|FB|DRM_KMS_HELPER|DRM_FBDEV_EMULATION)\>' .config CONFIG_DRM=y CONFIG_DRM_KMS_HELPER=m CONFIG_DRM_FBDEV_EMULATION=y CONFIG_FB=y 5.16-rc1 builds just fine -- investigating why… > My previous patch correctly addressed the possible link failure, but as > Jani points out, the dependency is now stricter than it needs to be. > > Change it again, to allow DRM_FBDEV_EMULATION to be used when > DRM_KMS_HELPER and FB are both loadable modules and DRM is linked into > the kernel. > > As a side-effect, the option is now only visible when at least one DRM > driver makes use of DRM_KMS_HELPER. This is better, because the option > has no effect otherwise. > > Fixes: 606b102876e3 ("drm: fb_helper: fix CONFIG_FB dependency") > Suggested-by: Acked-by: Jani Nikula > Reviewed-by: Javier Martinez Canillas > Signed-off-by: Arnd Bergmann > Signed-off-by: Daniel Vetter > Link: https://patchwork.freedesktop.org/patch/msgid/20211029120307.1407047-1-arnd@kernel.org > Signed-off-by: Sasha Levin > --- > drivers/gpu/drm/Kconfig | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index 9199f53861cac..6ae4269118af3 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -102,9 +102,8 @@ config DRM_DEBUG_DP_MST_TOPOLOGY_REFS > > config DRM_FBDEV_EMULATION > bool "Enable legacy fbdev support for your modesetting driver" > - depends on DRM > - depends on FB=y || FB=DRM > - select DRM_KMS_HELPER > + depends on DRM_KMS_HELPER > + depends on FB=y || FB=DRM_KMS_HELPER > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > -- js suse labs