From: Markus Elfring <Markus.Elfring@web.de>
To: Bernard Zhao <bernard@vivo.com>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, opensource.kernel@vivo.com,
"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Shashank Sharma" <shashank.sharma@intel.com>,
"Uma Shankar" <uma.shankar@intel.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drivers/video: cleanup coding style in video a bit
Date: Mon, 27 Apr 2020 10:36:06 +0200 [thread overview]
Message-ID: <9ffb6645-5802-3163-2107-435392a777f6@web.de> (raw)
> Eliminate the magic numbers, add vender infoframe size macro
> like other hdmi modules.
How do you think about a wording variant like the following?
Subject:
[PATCH v2] video/hdmi: Use “HDMI_VENDOR_INFOFRAME_SIZE” in hdmi_vendor_infoframe_init()
Change description:
Adjust the usage of a “magic” number here by adding a macro for
the vendor info frame size (similar to other video modules).
Regards,
Markus
next reply other threads:[~2020-04-27 8:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 8:36 Markus Elfring [this message]
[not found] <CGME20200427080542eucas1p172bdcfd22affc288ec1ceaadf0dad2b0@eucas1p1.samsung.com>
2020-04-27 8:05 ` [PATCH] drivers/video: cleanup coding style in video a bit Bernard Zhao
2020-06-01 13:25 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ffb6645-5802-3163-2107-435392a777f6@web.de \
--to=markus.elfring@web.de \
--cc=b.zolnierkie@samsung.com \
--cc=bernard@vivo.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=shashank.sharma@intel.com \
--cc=uma.shankar@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).