From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933210AbbHDLBR (ORCPT ); Tue, 4 Aug 2015 07:01:17 -0400 Received: from fw-tnat.cambridge.arm.com ([217.140.96.140]:37084 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933178AbbHDLAx (ORCPT ); Tue, 4 Aug 2015 07:00:53 -0400 From: Punit Agrawal To: Guenter Roeck Cc: linux-pm@vger.kernel.org, lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, liviu.dudau@arm.com, Eduardo Valentin , Zhang Rui Subject: Re: [PATCH v2 04/10] thermal: Fix thermal_zone_of_sensor_register to match documentation References: <1438615378-14241-1-git-send-email-punit.agrawal@arm.com> <1438615378-14241-5-git-send-email-punit.agrawal@arm.com> <55BF8F25.9010305@roeck-us.net> Date: Tue, 04 Aug 2015 12:00:41 +0100 In-Reply-To: <55BF8F25.9010305@roeck-us.net> (Guenter Roeck's message of "Mon, 03 Aug 2015 08:56:21 -0700") Message-ID: <9hha8u7mi7a.fsf@e105922-lin.cambridge.arm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Guenter Roeck writes: > On 08/03/2015 08:22 AM, Punit Agrawal wrote: >> thermal_zone_of_sensor_register is documented as returning a pointer >> to either a valid thermal_zone_device on success, or a corresponding >> ERR_PTR() value. >> >> In contrast, the function returns NULL when THERMAL_OF is configured >> off. Fix this. >> >> Signed-off-by: Punit Agrawal >> Cc: Guenter Roeck >> Cc: Eduardo Valentin >> Cc: Zhang Rui > > Acked-by: Guenter Roeck > Thanks, Guenter. >> --- >> include/linux/thermal.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/linux/thermal.h b/include/linux/thermal.h >> index 037e9df..a47b34a 100644 >> --- a/include/linux/thermal.h >> +++ b/include/linux/thermal.h >> @@ -364,7 +364,7 @@ static inline struct thermal_zone_device * >> thermal_zone_of_sensor_register(struct device *dev, int id, void *data, >> const struct thermal_zone_of_device_ops *ops) >> { >> - return NULL; >> + return ERR_PTR(-ENOSYS); >> } >> >> static inline >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html