From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755165AbbHNMiu (ORCPT ); Fri, 14 Aug 2015 08:38:50 -0400 Received: from fw-tnat.cambridge.arm.com ([217.140.96.140]:36252 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752286AbbHNMit (ORCPT ); Fri, 14 Aug 2015 08:38:49 -0400 From: Punit Agrawal To: Eduardo Valentin Cc: Zhang Rui Cc: Liviu Dudau Cc: "linux-pm\@vger.kernel.org" , "lm-sensors\@lm-sensors.org" , "linux-kernel\@vger.kernel.org" , "devicetree\@vger.kernel.org" , Rob Herring , Mark Rutland , Sudeep Holla Subject: Re: [PATCH v2 10/10] arm64: dts: Create SoC thermal zone for Juno References: <1438615378-14241-1-git-send-email-punit.agrawal@arm.com> <1438615378-14241-11-git-send-email-punit.agrawal@arm.com> <20150812155500.GW20890@e106497-lin.cambridge.arm.com> <9hh1tf7i7oi.fsf@e105922-lin.cambridge.arm.com> Date: Fri, 14 Aug 2015 13:38:35 +0100 In-Reply-To: <9hh1tf7i7oi.fsf@e105922-lin.cambridge.arm.com> (Punit Agrawal's message of "Thu, 13 Aug 2015 15:28:45 +0100") Message-ID: <9hhsi7mgi44.fsf@e105922-lin.cambridge.arm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ adding Eduardo, Rui for their take on OF-thermal bindings ] Punit Agrawal writes: > Hi Liviu, > > Thanks for having a look. > > Liviu Dudau writes: > >> On Mon, Aug 03, 2015 at 04:22:58PM +0100, Punit Agrawal wrote: >>> Setup a thermal zone driven by the SoC temperature sensor on Juno >>> r0. Create passive trip points and bind them to cpufreq cooling >>> devices that support the power extensions. >> >> Hi Punit, >> >>> >>> Signed-off-by: Punit Agrawal >>> Cc: Rob Herring >>> Cc: Mark Rutland >>> Cc: Liviu Dudau >>> Cc: Sudeep Holla >>> --- >>> arch/arm64/boot/dts/arm/juno.dts | 50 ++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 50 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/arm/juno.dts b/arch/arm64/boot/dts/arm/juno.dts >>> index d2e67f3..664961c 100644 >>> --- a/arch/arm64/boot/dts/arm/juno.dts >>> +++ b/arch/arm64/boot/dts/arm/juno.dts >>> @@ -9,6 +9,7 @@ >>> /dts-v1/; >>> >>> #include >>> +#include >>> >>> / { >>> model = "ARM Juno development board (r0)"; >>> @@ -90,6 +91,8 @@ >>> next-level-cache = <&A57_L2>; >>> clocks = <&scpi_dvfs 0>; >>> cpu-idle-states = <&CPU_SLEEP_0 &CLUSTER_SLEEP_0>; >>> + #cooling-cells = <2>; >>> + dynamic-power-coefficient = <530>; >> >> The Documentation/devicetree/bindings/thermal/thermal.txt document describes two additional >> required properties, cooling-min-state and cooling-max-state which are missing here. >> > > The bindings do suggest that the cooling-*-state are required but I > couldn't find any code making use of this property. > > I'll send a patch with the next version making those properties > optional. > On second thoughts... The question about cooling-*-state has come up in another thread as well [0]. I'll re-iterate the question for the thermal maintainers to clarify. The cooling-{max,min}-state properties are marked mandatory in the bindings but aren't used in the code anywhere. Can we drop those properties from the binding documentation? Or at the least, make them optional? [...] > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html