From: Nadav Amit <namit@vmware.com>
To: Ingo Molnar <mingo@kernel.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
X86 ML <x86@kernel.org>, Sam Ravnborg <sam@ravnborg.org>,
Michal Marek <michal.lkml@markovi.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
"linux-xtensa@linux-xtensa.org" <linux-xtensa@linux-xtensa.org>
Subject: Re: [PATCH v6 1/9] Makefile: Prepare for using macros for inline asm
Date: Tue, 24 Jul 2018 18:04:06 +0000 [thread overview]
Message-ID: <A1E263C1-C1DA-4B23-8232-8CF87DDD7A3F@vmware.com> (raw)
In-Reply-To: <20180724111445.GB14212@gmail.com>
at 4:14 AM, Ingo Molnar <mingo@kernel.org> wrote:
>
> * Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
>
>> 2018-06-23 2:22 GMT+09:00 Nadav Amit <namit@vmware.com>:
>>> Using macros for inline assembly improves both readability and
>>> compilation decisions that are distorted by big assembly blocks that use
>>> alternative sections. Compile macros.S and use it to assemble all C
>>> files. Currently, only x86 will use it.
>>>
>>> Cc: Sam Ravnborg <sam@ravnborg.org>
>>> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
>>> Cc: Michal Marek <michal.lkml@markovi.net>
>>> Cc: Thomas Gleixner <tglx@linutronix.de>
>>> Cc: Ingo Molnar <mingo@redhat.com>
>>> Cc: "H. Peter Anvin" <hpa@zytor.com>
>>> Cc: x86@kernel.org
>>> Cc: linux-kbuild@vger.kernel.org
>>> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
>>> Signed-off-by: Nadav Amit <namit@vmware.com>
>>> ---
>>
>>
>>
>> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>>
>>
>>
>>
>>> Makefile | 9 +++++++--
>>> arch/x86/Makefile | 11 +++++++++--
>>> arch/x86/kernel/macros.S | 7 +++++++
>>> scripts/Kbuild.include | 4 +++-
>>> scripts/mod/Makefile | 2 ++
>>> 5 files changed, 28 insertions(+), 5 deletions(-)
>>> create mode 100644 arch/x86/kernel/macros.S
>
> So this patch appears to break the xtensa cross-build on my system, with an older
> version of crosstools:
>
> MODPOST vmlinux.o
> /home/mingo/crosstool-korg/bin//gcc-4.9.0-nolibc/xtensa-linux/bin/xtensa-linux-ld:./arch/xtensa/kernel/vmlinux.lds:430:
> syntax error
> /home/mingo/tip/Makefile:1010: recipe for target 'vmlinux' failed
> make[1]: *** [vmlinux] Error 1
> make[1]: Leaving directory '/dev/shm/tip/build'
> Makefile:146: recipe for target 'sub-make’ failed
This one is due to a missing -DLINKER_SCRIPT in the Makefile of xtensa. I’ll
send the patch to fix it after I deal with the boot failure (for which I
wait for your config file).
Thanks,
Nadav
next prev parent reply other threads:[~2018-07-24 18:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 17:22 [PATCH v6 0/9] x86: macrofying inline asm for better compilation Nadav Amit
2018-06-22 17:22 ` [PATCH v6 1/9] Makefile: Prepare for using macros for inline asm Nadav Amit
2018-07-18 1:46 ` Masahiro Yamada
2018-07-24 11:14 ` Ingo Molnar
2018-07-24 18:04 ` Nadav Amit [this message]
2018-06-22 17:22 ` [PATCH v6 2/9] x86: objtool: use asm macro for better compiler decisions Nadav Amit
2018-06-22 17:22 ` [PATCH v6 3/9] x86: refcount: prevent gcc distortions Nadav Amit
2018-06-22 17:22 ` [PATCH v6 4/9] x86: alternatives: macrofy locks for better inlining Nadav Amit
2018-06-22 17:22 ` [PATCH v6 5/9] x86: bug: prevent gcc distortions Nadav Amit
2018-06-22 17:22 ` [PATCH v6 6/9] x86: prevent inline distortion by paravirt ops Nadav Amit
2018-06-22 17:22 ` [PATCH v6 7/9] x86: extable: use macros instead of inline assembly Nadav Amit
2018-06-22 17:22 ` [PATCH v6 8/9] x86: cpufeature: " Nadav Amit
2018-06-22 17:22 ` [PATCH v6 9/9] x86: jump-labels: " Nadav Amit
2018-07-24 14:26 ` Ingo Molnar
2018-07-24 16:29 ` Nadav Amit
2018-07-24 19:49 ` Ingo Molnar
2018-07-11 1:59 ` [PATCH v6 0/9] x86: macrofying inline asm for better compilation Nadav Amit
2018-07-15 21:54 ` [kbuild ack?] " Ingo Molnar
2018-07-18 1:47 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A1E263C1-C1DA-4B23-8232-8CF87DDD7A3F@vmware.com \
--to=namit@vmware.com \
--cc=hpa@zytor.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=michal.lkml@markovi.net \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).