From: "Liu, Yi L" <yi.l.liu@intel.com>
To: "alex.williamson@redhat.com" <alex.williamson@redhat.com>
Cc: "kwankhede@nvidia.com" <kwankhede@nvidia.com>,
"Tian, Kevin" <kevin.tian@intel.com>,
"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
"Sun, Yi Y" <yi.y.sun@intel.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Zhao, Yan Y" <yan.y.zhao@intel.com>,
"He, Shaopeng" <shaopeng.he@intel.com>,
"Xia, Chenbo" <chenbo.xia@intel.com>,
"Tian, Jun J" <jun.j.tian@intel.com>
Subject: Re: [PATCH v2 12/13] vfio/type1: use iommu_attach_group() for wrapping PF/VF as mdev
Date: Mon, 30 Sep 2019 12:40:59 +0000 [thread overview]
Message-ID: <A2975661238FB949B60364EF0F2C25743A0B5600@SHSMSX104.ccr.corp.intel.com> (raw)
Hi Alex,
> From: Alex Williamson [mailto:alex.williamson@redhat.com]
> Sent: Thursday, September 26, 2019 10:37 AM
> To: Liu, Yi L <yi.l.liu@intel.com>
> Subject: Re: [PATCH v2 12/13] vfio/type1: use iommu_attach_group() for wrapping
> PF/VF as mdev
>
> On Thu, 5 Sep 2019 15:59:29 +0800
> Liu Yi L <yi.l.liu@intel.com> wrote:
>
> > This patch uses iommu_attach_group() to do group attach when it is for
> > the case of wrapping a PF/VF as a mdev. iommu_attach_device() doesn't
> > support non-singleton iommu group attach. With this change, wrapping
> > PF/VF as mdev can work on non-singleton iommu groups.
> >
> > Cc: Kevin Tian <kevin.tian@intel.com>
> > Cc: Lu Baolu <baolu.lu@linux.intel.com>
> > Suggested-by: Alex Williamson <alex.williamson@redhat.com>
> > Signed-off-by: Liu Yi L <yi.l.liu@intel.com>
> > ---
> > drivers/vfio/vfio_iommu_type1.c | 22 ++++++++++++++++++----
> > 1 file changed, 18 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/vfio/vfio_iommu_type1.c
> > b/drivers/vfio/vfio_iommu_type1.c index 054391f..317430d 100644
> > --- a/drivers/vfio/vfio_iommu_type1.c
> > +++ b/drivers/vfio/vfio_iommu_type1.c
> > @@ -1312,13 +1312,20 @@ static int vfio_mdev_attach_domain(struct
> > device *dev, void *data) {
> > struct iommu_domain *domain = data;
> > struct device *iommu_device;
> > + struct iommu_group *group;
> >
> > iommu_device = vfio_mdev_get_iommu_device(dev);
> > if (iommu_device) {
> > if (iommu_dev_feature_enabled(iommu_device,
> IOMMU_DEV_FEAT_AUX))
> > return iommu_aux_attach_device(domain, iommu_device);
> > - else
> > - return iommu_attach_device(domain, iommu_device);
> > + else {
> > + group = iommu_group_get(iommu_device);
> > + if (!group) {
> > + WARN_ON(1);
>
> What's the value of the WARN_ON here and below?
Let me remove it.
> iommu_group_get() increments the kobject reference, looks like it's leaked. Thanks,
Oops, yes, should use dev->iommu_group. Let me fix it.
>
> Alex
Thanks,
Yi Liu
next reply other threads:[~2019-09-30 12:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 12:40 Liu, Yi L [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-09-05 7:59 [PATCH v2 00/13] vfio_pci: wrap pci device as a mediated device Liu Yi L
2019-09-05 7:59 ` [PATCH v2 12/13] vfio/type1: use iommu_attach_group() for wrapping PF/VF as mdev Liu Yi L
2019-09-26 2:37 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2975661238FB949B60364EF0F2C25743A0B5600@SHSMSX104.ccr.corp.intel.com \
--to=yi.l.liu@intel.com \
--cc=alex.williamson@redhat.com \
--cc=baolu.lu@linux.intel.com \
--cc=chenbo.xia@intel.com \
--cc=joro@8bytes.org \
--cc=jun.j.tian@intel.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shaopeng.he@intel.com \
--cc=yan.y.zhao@intel.com \
--cc=yi.y.sun@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).