From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60248C5B54D for ; Thu, 27 Jun 2019 22:04:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3651E205F4 for ; Thu, 27 Jun 2019 22:04:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k9M4knlr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726666AbfF0WEj (ORCPT ); Thu, 27 Jun 2019 18:04:39 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:44111 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726559AbfF0WEi (ORCPT ); Thu, 27 Jun 2019 18:04:38 -0400 Received: by mail-pg1-f193.google.com with SMTP id n2so1611156pgp.11; Thu, 27 Jun 2019 15:04:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version; bh=nwwqo4OMPeEp/3IvNc965PpLmTMXL18lTWD4uQTEbxg=; b=k9M4knlrXmd61R4DWvoUMohmYUxb/A9pCr+92MQMtINw53nqb+ZEwK8VPwSOe9WvyH ND/WwVP3k0Jm1dN3WXj90f18Wvgm1+jQA0U55MWXWNp8709JP5TsylXTPjWRs8tIcNUw pItPz46en9YOYUacBWyZp4D3iHnPS3RmcOgFftYlzeW48UC8E0KaqfcrVeY2XbQhrBsy HmoEw53UOTPCzAZV6kxh10nHhIBwovvXknCyX2bVYmdujPQd/U/EPf8zd30tB1oQTHAz uU3FQs5mxUXfogUdrLMJJQuuPK0x6tkv9tepqk6Tgqab/KZZ4EV1y4Wjszr45buNUp1X YffQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version; bh=nwwqo4OMPeEp/3IvNc965PpLmTMXL18lTWD4uQTEbxg=; b=Mfw+DcSpXVbvfW568g/7xhmyXtgGpLkxHC2TMZEojbTn3T6GxvfmC4ffoIpk7CwiFc vqUauKSk+Em+Ljqm4L7YDMyHf9+SS0HRjjFW9ckMTfDyDWzEGWde+Fq4GvTM/8vW71U7 a63KYTck+LtvllFPCkT5Yija0/v8lhoNgZqphFUMZY7rlOA0xJ9i3PaqQJ4ya7poLcC/ sExAwhXv5X1Hl0eGbGzbnznBREpFDgRN2b4wOGk43nXBoTPjcD2XFcsnk5PnRPhhKbrO h1Bwd1tiouyGdD6btkWjjij0Wak3kiGhrCNbFU0+ip1mWdBMx9ervv1qHBmjbk80wWC1 VgVA== X-Gm-Message-State: APjAAAVQuDrhQ1KGxoxqSRj7I9cV1qohxd6MrnVTrzvsu8sno485/CM8 dnlJoAaQ5aQM++WsyqwbEqQ= X-Google-Smtp-Source: APXvYqzc5FveAOMflX5HizDh+qcNJBUHsV98YFwrtDsRstppx0pvQuvUX8PBO/hqOmo62KjAsFUjhA== X-Received: by 2002:a63:4f5b:: with SMTP id p27mr5800716pgl.273.1561673077880; Thu, 27 Jun 2019 15:04:37 -0700 (PDT) Received: from [172.20.53.102] ([2620:10d:c090:200::6693]) by smtp.gmail.com with ESMTPSA id p2sm70688pfb.118.2019.06.27.15.04.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jun 2019 15:04:37 -0700 (PDT) From: "Jonathan Lemon" To: "Ilya Maximets" Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, xdp-newbies@vger.kernel.org, "David S. Miller" , "=?utf-8?b?QmrDtnJuIFTDtnBlbA==?=" , "Magnus Karlsson" , "Jakub Kicinski" , "Daniel Borkmann" Subject: Re: [PATCH bpf v5 1/2] xdp: hold device for umem regardless of zero-copy mode Date: Thu, 27 Jun 2019 15:04:35 -0700 X-Mailer: MailMate (1.12.5r5635) Message-ID: In-Reply-To: <20190627101529.11234-2-i.maximets@samsung.com> References: <20190627101529.11234-1-i.maximets@samsung.com> <20190627101529.11234-2-i.maximets@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27 Jun 2019, at 3:15, Ilya Maximets wrote: > Device pointer stored in umem regardless of zero-copy mode, > so we heed to hold the device in all cases. > > Fixes: c9b47cc1fabc ("xsk: fix bug when trying to use both copy and > zero-copy on one queue id") > Signed-off-by: Ilya Maximets Acked-by: Jonathan Lemon