From: Nadav Amit <namit@vmware.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Julien Freche <jfreche@vmware.com>,
Xavier Deguillard <xdeguillard@vmware.com>,
Pv-drivers <Pv-drivers@vmware.com>, Arnd Bergmann <arnd@arndb.de>,
LKML <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] vmw_balloon: release lock on error in vmballoon_reset()
Date: Mon, 11 Feb 2019 19:12:40 +0000 [thread overview]
Message-ID: <A3173F98-AE61-48DF-8AA8-6757C3C086F7@vmware.com> (raw)
In-Reply-To: <20190211184545.GC22106@kadam>
> On Feb 11, 2019, at 10:45 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> We added some locking to this function but forgot to drop the lock on
> these two error paths. This bug would lead to an immediate deadlock.
>
> Fixes: c7b3690fb152 ("vmw_balloon: stats rework")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: stable@vger.kernel.org
Reviewed-by: Nadav Amit <namit@vmware.com>
--
Yes, I screwed up. Thanks for catching it!
I’ll go to check why my error injection tests didn’t catch it.
prev parent reply other threads:[~2019-02-11 19:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 18:45 [PATCH] vmw_balloon: release lock on error in vmballoon_reset() Dan Carpenter
2019-02-11 19:12 ` Nadav Amit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A3173F98-AE61-48DF-8AA8-6757C3C086F7@vmware.com \
--to=namit@vmware.com \
--cc=Pv-drivers@vmware.com \
--cc=arnd@arndb.de \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=jfreche@vmware.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xdeguillard@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).