From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751639AbbESAjS (ORCPT ); Mon, 18 May 2015 20:39:18 -0400 Received: from mail-by2on0143.outbound.protection.outlook.com ([207.46.100.143]:62878 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751048AbbESAjP (ORCPT ); Mon, 18 May 2015 20:39:15 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; googlemail.com; dkim=none (message not signed) header.d=none; X-WSS-ID: 0NOKIV2-07-SWC-02 X-M-MSG: From: "Deucher, Alexander" To: Denys Vlasenko , "Koenig, Christian" CC: Denys Vlasenko , Linux Kernel Mailing List Subject: RE: [PATCH v2] radeon: Deinline indirect register accessor functions Thread-Topic: [PATCH v2] radeon: Deinline indirect register accessor functions Thread-Index: AQHQkZ06td+krMLBxk2513mUHsuhfp2CXEKAgAA9jYD//8CvAA== Date: Mon, 18 May 2015 23:06:36 +0000 Message-ID: References: <1431975735-21039-1-git-send-email-dvlasenk@redhat.com> <555A38FF.6050407@amd.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.180.168.240] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD024;1:/1dvvEtPLKkXGtRu4WZ/bCYofgg2ZIf4KZBJdNiZI6+3l2uZScFFWK9tAq+rHcfYqo5vsYnZfgldtJH4H6NGOjoQ1Vr1BqKf2jEcoozljGUqDowotSrEWdfnqdpoPKLW20g7+F0bjnFgc8JBy/NH6L/Q8aLi7iB90aIYX4xBaPZKCOM8rFVWbjf+5UHpLTrAbFR0EQczc3Bz1Q9usZcVs2+RtX282nbJovRfMqBaYuQKadb8ezE7MoP2hzFk4MqU3gIonB71Ck0dAr28tQRhGviz5nYEex3CwoXSB031Rkw= X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(428002)(51704005)(199003)(189002)(13464003)(377454003)(24454002)(87936001)(55846006)(92566002)(46102003)(23676002)(53416004)(2656002)(101416001)(106466001)(106116001)(33656002)(105586002)(5001770100001)(54356999)(189998001)(5001860100001)(5001830100001)(2950100001)(76176999)(50986999)(64706001)(47776003)(50466002)(86362001)(19580395003)(19580405001)(4001540100001)(5250100002)(77156002)(102836002)(68736005)(2900100001)(97736004)(62966003)(2920100001);DIR:OUT;SFP:1102;SCL:1;SRVR:BLUPR02MB067;H:atltwp01.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR02MB067;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR02MB1220; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BLUPR02MB067;BCL:0;PCL:0;RULEID:;SRVR:BLUPR02MB067; X-Forefront-PRVS: 058043A388 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2015 23:06:39.8154 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR02MB067 X-OriginatorOrg: amd.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t4J0dQWm029790 > -----Original Message----- > From: Denys Vlasenko [mailto:vda.linux@googlemail.com] > Sent: Monday, May 18, 2015 6:50 PM > To: Koenig, Christian > Cc: Denys Vlasenko; Deucher, Alexander; Linux Kernel Mailing List > Subject: Re: [PATCH v2] radeon: Deinline indirect register accessor functions > > On Mon, May 18, 2015 at 9:09 PM, Christian König > wrote: > >> r600_uvd_ctx_rreg: 111 bytes, 4 callsites > >> r600_uvd_ctx_wreg: 113 bytes, 5 callsites > >> eg_pif_phy0_rreg: 106 bytes, 13 callsites > >> eg_pif_phy0_wreg: 108 bytes, 13 callsites > >> eg_pif_phy1_rreg: 107 bytes, 13 callsites > >> eg_pif_phy1_wreg: 108 bytes, 13 callsites > >> rv370_pcie_rreg: 111 bytes, 21 callsites > >> rv370_pcie_wreg: 113 bytes, 24 callsites > >> r600_rcu_rreg: 111 bytes, 16 callsites > >> r600_rcu_wreg: 113 bytes, 25 callsites > >> cik_didt_rreg: 106 bytes, 10 callsites > >> cik_didt_wreg: 107 bytes, 10 callsites > >> tn_smc_rreg: 106 bytes, 126 callsites > >> tn_smc_wreg: 107 bytes, 116 callsites > >> eg_cg_rreg: 107 bytes, 20 callsites > >> eg_cg_wreg: 108 bytes, 52 callsites > > > Sorry haven't noticed that before: > > > > radeon_device.c is most likely not the right place for the non-inlined > > functions. Please move them into to the appropriate files for each > > generation. > > Will do (probably tomorrow, not today). Is this whole exercise really worthwhile? This will be the 3rd or 4th time these have been inlined/uninlined. > > Can you help me here a bit? > There are LOTS of *.c files in drm/radeon/. > I guess r600_ functions should go into r600.c, Yes. > rv370_ to rv730_dpm.c (right?), No. rv370_ should go in r300.c > but some of the function names are less clear (to me). > > Where would you like eg_pif_phyN_r/wreg() go? evergreen.c? Yes. > Should eg_cg_r/wreg() also go to this file? Yes. > > cik_didt_r/wreg() - to cik.c? Yes. > > tn_smc_r/wreg()? Is tn = trinity? so, trinity_smc.c? ni.c Alex {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I