[PATCH] block: move the dereference below the NULL test

* [PATCH] block: move the dereference below the NULL test
@ 2012-09-07  7:04 Wei Yongjun
  2012-09-07  8:47 ` yongjun_wei
  0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2012-09-07  7:04 UTC (permalink / raw)
  To: grant.likely, rob.herring; +Cc: yongjun_wei, linux-kernel, devicetree-discuss

From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

The dereference should be moved below the NULL test.

spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 drivers/block/swim3.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/block/swim3.c b/drivers/block/swim3.c
index 89ddab1..25a522d 100644
--- a/drivers/block/swim3.c
+++ b/drivers/block/swim3.c
@@ -1090,13 +1090,14 @@ static const struct block_device_operations floppy_fops = {
 static void swim3_mb_event(struct macio_dev* mdev, int mb_state)
 {
 	struct floppy_state *fs = macio_get_drvdata(mdev);
-	struct swim3 __iomem *sw = fs->swim3;
+	struct swim3 __iomem *sw;
 
 	if (!fs)
 		return;
 	if (mb_state != MB_FD)
 		return;
 
+	sw = fs->swim3;
 	/* Clear state */
 	out_8(&sw->intr_enable, 0);
 	in_8(&sw->intr);


^ permalink raw reply related	[flat|nested] 2+ messages in thread