From: Jan Kotas <jank@cadence.com>
To: Rob Herring <robh@kernel.org>
Cc: Jan Kotas <jank@cadence.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
Rafal Ciepiela <rafalc@cadence.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] media: dt-bindings: Update bindings for Cadence CSI2RX version 2.1
Date: Mon, 19 Aug 2019 07:16:04 +0000 [thread overview]
Message-ID: <A3DAF408-887A-4913-B620-959BCD4E98D8@global.cadence.com> (raw)
In-Reply-To: <20190816211802.GA12657@bogus>
> On 16 Aug 2019, at 23:18, Rob Herring <robh@kernel.org> wrote:
>
>
> On Thu, Jul 25, 2019 at 11:26:46AM +0100, Jan Kotas wrote:
>> This patch adds a DT bindings documentation for
>> Cadence CSI2RX v2.1 controller.
>
> And 1.3?
OK, I’ll update the commit description.
>> Required properties:
>> - - compatible: must be set to "cdns,csi2rx" and an SoC-specific compatible
>> + - compatible: must be set to "cdns,csi2rx" or "cdns,csi2rx-1.3"
>> + for version 1.3 of the controller, "cdns,csi2rx-2.1" for v2.1
>> + and an SoC-specific compatible
>
> This wording is now not clear that an SoC-specific compatible is always
> required or just for 2.1. Please format one compatible per line.
OK, I will fix it in v2.
Thank you for the comments.
Regards,
Jan
next prev parent reply other threads:[~2019-08-19 7:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 10:26 [PATCH 0/3] media: Add support for Cadence CSI2RX version 2.1 Jan Kotas
2019-07-25 10:26 ` [PATCH 1/3] media: dt-bindings: Update bindings " Jan Kotas
2019-08-16 21:18 ` Rob Herring
2019-08-19 7:16 ` Jan Kotas [this message]
2019-07-25 10:26 ` [PATCH 2/3] media: Add lane checks for Cadence CSI2RX Jan Kotas
2019-07-25 10:26 ` [PATCH 3/3] media: Add support for Cadence CSI2RX 2.1 Jan Kotas
2019-08-01 7:36 ` [PATCH 0/3] media: Add support for Cadence CSI2RX version 2.1 Jan Kotas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A3DAF408-887A-4913-B620-959BCD4E98D8@global.cadence.com \
--to=jank@cadence.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=mchehab@kernel.org \
--cc=rafalc@cadence.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).