RE: [RFC] /sbin/hotplug multiplexor - take 2

RE: [RFC] /sbin/hotplug multiplexor - take 2

[Perez-Gonzalez, Inaky]

> From: Greg KH [mailto:greg@kroah.com]
>
> ...
>
> for I in "${DIR}/$1/"* "${DIR}/"all/* ; do
> 	test -x $I && $I $1 ;

test -x "$I" && "$I" "$1"

Just in case?

Iñaky Pérez-González -- Not speaking for Intel -- all opinions are my own
(and my fault)

Re: [RFC] /sbin/hotplug multiplexor - take 2

[Greg KH]

On Tue, Apr 15, 2003 at 05:01:40PM -0700, Perez-Gonzalez, Inaky wrote:
> 
> > From: Greg KH [mailto:greg@kroah.com]
> >
> > ...
> >
> > for I in "${DIR}/$1/"* "${DIR}/"all/* ; do
> > 	test -x $I && $I $1 ;
> 
> test -x "$I" && "$I" "$1"
> 
> Just in case?

Good idea, I've changed it.

thanks,

greg k-h

Re: [RFC] /sbin/hotplug multiplexor - take 2

[Greg KH]

On Wed, Apr 16, 2003 at 08:22:13AM +0200, Frederic Lepied wrote:
> Greg KH <greg@kroah.com> writes:
> 
> > Ok, based on the comments so far, how about this proposed version of
> > /sbin/hotplug to provide a multiplexor?
> 
> I think it would be good to launch only the files ending by a special
> extension to avoid running backup files. Something like that:

Ah, good idea, will do.

thanks,

greg k-h

Re: [RFC] /sbin/hotplug multiplexor - take 2

[Frederic Lepied]

Greg KH <greg@kroah.com> writes:

> Ok, based on the comments so far, how about this proposed version of
> /sbin/hotplug to provide a multiplexor?

I think it would be good to launch only the files ending by a special
extension to avoid running backup files. Something like that:

#!/bin/sh
DIR="/etc/hotplug.d"

for I in "${DIR}/$1/"*.hotplug "${DIR}/"all/*.hotplug ; do
	test -x $I && $I $1 ;
done
-- 
Fred - May the source be with you

Re: [RFC] /sbin/hotplug multiplexor - take 2

[Greg KH]

On Tue, Apr 15, 2003 at 12:19:51PM -0700, David Brownell wrote:
> Greg KH wrote:
> >Ok, based on the comments so far, how about this proposed version of
> >/sbin/hotplug to provide a multiplexor?
> 
> It'd be a reduction in functionality.  I could no longer just
> type "/sbin/hotplug" to see what agents disabled or missing ...
> or notice that since hotplugging was on, the problem had to be
> RH9 storing /bin/true into /proc/sys/kernel/hotplug again!  :P

Well you can still do that, the current scripts will get run that way
too.

> If the idea is just to loosen today's "one agent per event"
> rule (I've had that idea too), then wouldn't it be simpler to
> just (a1) pay an extra process context, not using "exec" to run
> /etc/hotplug/$1.agent, and when it returns (a2) THEN try other
> programs?  Or even (b) just modify appropriate agent scripts
> to do so, instead of /sbin/hotplug?
> 
> I'd think better about this problem if I had a handful of
> examples showing why category-specific or event-specific
> dispatch wouldn't be preferable.

udev is such an example.  I want it to run for every hotplug event.  To
do that with the current scripts, I have to either modify the current
scripts to always call it (not a big deal, I have CVS access :) or add a
handler for every type of device, and every type of those devices.

devlabel is also another type of example.  The author of that had to
persuade us to modify the scripts in order to get support for his
program.  I don't want to be a gating function, with this simple
proposal, he could just dump the devlabel script into the /etc/hotplug.d
directory in the proper place and everything would just work.

I've also been hearing from lots of other people (interestingly, not
publicly, I guess they like to stay hidden for some reason) that also
hook the hotplug scripts.  They have usually been either recommending
that their users patch the current script, or just replace the current
ones all together (thereby loosing the module load functionality) in
order to support their devices.  This proposal would also help them, and
their users.

thanks,

greg k-h

Re: [RFC] /sbin/hotplug multiplexor - take 2

[David Brownell]

Greg KH wrote:
> Ok, based on the comments so far, how about this proposed version of
> /sbin/hotplug to provide a multiplexor?

It'd be a reduction in functionality.  I could no longer just
type "/sbin/hotplug" to see what agents disabled or missing ...
or notice that since hotplugging was on, the problem had to be
RH9 storing /bin/true into /proc/sys/kernel/hotplug again!  :P

If the idea is just to loosen today's "one agent per event"
rule (I've had that idea too), then wouldn't it be simpler to
just (a1) pay an extra process context, not using "exec" to run
/etc/hotplug/$1.agent, and when it returns (a2) THEN try other
programs?  Or even (b) just modify appropriate agent scripts
to do so, instead of /sbin/hotplug?

I'd think better about this problem if I had a handful of
examples showing why category-specific or event-specific
dispatch wouldn't be preferable.

- Dave



> ----------
> #!/bin/sh
> DIR="/etc/hotplug.d"
> 
> for I in "${DIR}/$1/"* "${DIR}/"all/* ; do
> 	test -x $I && $I $1 ;
> done
> 
> exit 1
> ----------

[RFC] /sbin/hotplug multiplexor - take 2

[Greg KH]

Ok, based on the comments so far, how about this proposed version of
/sbin/hotplug to provide a multiplexor?

thanks,

greg k-h

----------
#!/bin/sh
DIR="/etc/hotplug.d"

for I in "${DIR}/$1/"* "${DIR}/"all/* ; do
	test -x $I && $I $1 ;
done

exit 1
----------