From: Kai-Heng Feng <kai.heng.feng@canonical.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Jiri Kosina <jikos@kernel.org>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] HID: multitouch: Remove MT_CLS_WIN_8_DUAL
Date: Wed, 27 May 2020 14:19:16 +0800 [thread overview]
Message-ID: <A51B9D28-88BF-42EB-9161-8E3081B128D2@canonical.com> (raw)
In-Reply-To: <CAO-hwJ+mTjVpBiY9vHXA2Y6D+cXYemixFJ++i+KwZZ25Z6LHHA@mail.gmail.com>
> On May 26, 2020, at 16:43, Benjamin Tissoires <benjamin.tissoires@redhat.com> wrote:
>
> On Tue, May 26, 2020 at 10:24 AM Jiri Kosina <jikos@kernel.org> wrote:
>>
>> On Tue, 14 Apr 2020, Kai-Heng Feng wrote:
>>
>>> After commit c23e2043d5f7 ("HID: multitouch: do not filter mice nodes"),
>>> MT_CLS_WIN_8 also supports mouse nodes, hence make MT_CLS_WIN_8_DUAL
>>> redundant.
>>>
>>> Remove MT_CLS_WIN_8_DUAL accordingly.
>>
>> Benjamin, can I get your Ack on this one please?
>
> Heh, funny enough I was trying to fix
> https://bugzilla.kernel.org/show_bug.cgi?id=207235 and was pondering
> this one too.
>
> To fix #207235, I'll likely need to add a new class and quirk in
> hid-multitouch. I can't really find a generic solution for now, and we
> better have a local quirk for the 2 devices we currently have and
> backport those to stable. However, this patch will likely conflict
> (trivially), with the new quirks, so I was thinking:
> - submitting my quick and dirty quirk and mark it to stable
> - apply this one on top of it (this one really doesn't need to go to stable)
>
> How does that sound?
Sounds good. I'll resend this patch once your patch lands in the tree.
Kai-Heng
>
> Cheers,
> Benjamin
>
>>
>> Thanks,
>>
>> --
>> Jiri Kosina
>> SUSE Labs
>>
>
next prev parent reply other threads:[~2020-05-27 6:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 9:18 [PATCH] HID: multitouch: Remove MT_CLS_WIN_8_DUAL Kai-Heng Feng
2020-05-08 5:33 ` Kai-Heng Feng
2020-05-26 8:23 ` Jiri Kosina
2020-05-26 8:43 ` Benjamin Tissoires
2020-05-27 6:19 ` Kai-Heng Feng [this message]
2020-05-27 9:24 ` Benjamin Tissoires
2020-05-27 12:15 ` Benjamin Tissoires
2020-05-28 9:36 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A51B9D28-88BF-42EB-9161-8E3081B128D2@canonical.com \
--to=kai.heng.feng@canonical.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).