From: Nadav Amit <nadav.amit@gmail.com>
To: Pavel Begunkov <asml.silence@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: Lockdep warning on io_file_data_ref_zero() with 5.10-rc5
Date: Sat, 28 Nov 2020 16:21:36 -0800 [thread overview]
Message-ID: <A68B2535-0B9D-43C9-9762-AE8427E64773@gmail.com> (raw)
In-Reply-To: <c16232dd-5841-6e87-bbd0-0c18f0fc982b@gmail.com>
> On Nov 28, 2020, at 4:13 PM, Pavel Begunkov <asml.silence@gmail.com> wrote:
>
> On 28/11/2020 23:59, Nadav Amit wrote:
>> Hello Pavel,
>>
>> I got the following lockdep splat while rebasing my work on 5.10-rc5 on the
>> kernel (based on 5.10-rc5+).
>>
>> I did not actually confirm that the problem is triggered without my changes,
>> as my iouring workload requires some kernel changes (not iouring changes),
>> yet IMHO it seems pretty clear that this is a result of your commit
>> e297822b20e7f ("io_uring: order refnode recycling”), that acquires a lock in
>> io_file_data_ref_zero() inside a softirq context.
>
> Yeah, that's true. It was already reported by syzkaller and fixed by Jens, but
> queued for 5.11. Thanks for letting know anyway!
>
> https://lore.kernel.org/io-uring/948d2d3b-5f36-034d-28e6-7490343a5b59@kernel.dk/T/#t
Thanks for the quick response and sorry for the noise. I should improve my
Googling abilities and check the iouring repository the next time.
Regards,
Nadav
next prev parent reply other threads:[~2020-11-29 0:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-28 23:59 Lockdep warning on io_file_data_ref_zero() with 5.10-rc5 Nadav Amit
2020-11-29 0:13 ` Pavel Begunkov
2020-11-29 0:21 ` Nadav Amit [this message]
2020-11-30 18:16 ` Jens Axboe
2020-12-15 6:58 ` Xiaoguang Wang
2020-12-15 16:18 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A68B2535-0B9D-43C9-9762-AE8427E64773@gmail.com \
--to=nadav.amit@gmail.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).