From: Bill Huang <email@example.com>
To: "'Stephen Warren'" <firstname.lastname@example.org>
Cc: "'Thierry Reding'" <email@example.com>,
Laxman Dewangan <firstname.lastname@example.org>, Xin Xie <email@example.com>,
Rhyland Klein <firstname.lastname@example.org>,
Subject: RE: [PATCH v2 1/2] mfd: dt: tps6586x: Add power off control
Date: Mon, 27 Aug 2012 13:40:51 +0800 [thread overview]
Message-ID: <A7051F87A141B744BCAF487D48E5B3BDF5BA98284E@HKMAIL02.nvidia.com> (raw)
> On 08/24/2012 06:36 PM, Bill Huang wrote:
> >>> On Sun, Aug 19, 2012 at 06:07:55PM -0700, Bill Huang wrote:
> >>>> Add DT property "ti,system-power-controller" telling whether or not
> >>>> this pmic is in charge of controlling the system power, so the
> >>>> power off routine can be hooked up to system call "pm_power_off".
> >>> I've seen the following while trying this patch applied on top of next-20120817:
> >>> [ 40.581151] Power down.
> >>> [ 41.583160] ------------[ cut here ]------------
> >>> [ 41.587784] WARNING: at /home/thierry.reding/src/kernel/linux-ipmp.git/drivers/i2c/busses/i2c-
> >>> tegra.c:525 tegra_i2c_xfer+0x21c/0x29c()
> >> Thanks Thierry, I can repro this on Tegra20 inconsistently and found,
> >> if current cpu is not cpu0 when doing "machine_shutdown" (it will
> >> call "smp_send_stop"), i2c controller will failed to do any transaction (looks like gic interrupt
> will be disabled), I'll debug further to find out the root cause.
> >> By the way, Tegra30 is good since it will always be cpu0 when doing
> >> "machine_shutdown", I still don't know why it makes the difference
> >> against Tegra20 since I'm not familiar with those cpu stuffs and what make it behave differently,
> I'll study a bit, thanks.
> > I've sent the shutdown issue for discussion in ARM list: Shutdown problem in SMP system happened on
> > The cause of the i2c timeout is pretty clear now and it is not
> > directly related to this patch, so is this patch series acceptable? Any thoughts or comment? Thanks.
> I tend to agree; power off never worked without this patch, and sometimes does with the patch, due to
> nothing wrong with this patch.
> Bill, please do follow up on getting the underlying Tegra issue solved somehow though. IIRC, Joseph Lo
> or Prashant has a patch which enabled the config option that Russell mentioned, so the fix may just be
> to wait for that patch to get finalized, but please double-check that solves it.
As per the shutdown issue discussion, enabling CONFIG_PM_SLEEP_SMP is the only solution and I've confirmed that fix the issue, thanks.
next prev parent reply other threads:[~2012-08-27 5:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 1:07 [PATCH v2 0/2] mfd: dt: add power off support for Tegra20/Tegra30 Bill Huang
2012-08-20 1:07 ` [PATCH v2 1/2] mfd: dt: tps6586x: Add power off control Bill Huang
2012-08-20 11:34 ` Thierry Reding
2012-08-22 12:07 ` Bill Huang
2012-08-25 0:36 ` Bill Huang
2012-08-25 3:34 ` Stephen Warren
2012-08-27 5:40 ` Bill Huang [this message]
2012-09-05 0:28 ` Bill Huang
2012-08-20 1:07 ` [PATCH v2 2/2] mfd: dt: tps65910: add " Bill Huang
2012-09-11 10:25 ` [PATCH v2 0/2] mfd: dt: add power off support for Tegra20/Tegra30 Bill Huang
2012-09-11 10:46 ` Thierry Reding
2012-09-11 15:15 ` Stephen Warren
2012-09-11 16:08 ` Samuel Ortiz
2012-09-11 16:26 ` Stephen Warren
2012-09-11 18:56 ` Samuel Ortiz
2012-09-11 16:07 ` Samuel Ortiz
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).