From: "Manjunathappa, Prakash" <prakash.pm@ti.com>
To: "Manjunathappa, Prakash" <prakash.pm@ti.com>,
Mark Rutland <mark.rutland@arm.com>
Cc: "Porter, Matt" <mporter@ti.com>,
"davinci-linux-open-source@linux.davincidsp.com"
<davinci-linux-open-source@linux.davincidsp.com>,
"hs@denx.de" <hs@denx.de>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"cjb@laptop.org" <cjb@laptop.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v2 2/3] mmc: davinci_mmc: add DT support
Date: Mon, 11 Feb 2013 05:31:47 +0000 [thread overview]
Message-ID: <A73F36158E33644199EB82C5EC81C7BC3EA46794@DBDE01.ent.ti.com> (raw)
In-Reply-To: <A73F36158E33644199EB82C5EC81C7BC3EA465FE@DBDE01.ent.ti.com>
Hi Mark,
On Fri, Feb 08, 2013 at 11:55:09, Manjunathappa, Prakash wrote:
> Hi Mark,
>
> On Thu, Feb 07, 2013 at 16:16:56, Mark Rutland wrote:
> > Hello,
> >
> > I have a couple of comments on the dt bindings and the way it's parsed.
> >
>
> Thanks for your review comments.
>
> > On Thu, Feb 07, 2013 at 07:57:04AM +0000, Manjunathappa, Prakash wrote:
> > > Adds device tree support for davinci_mmc. Also add binding documentation.
> > > Tested in non-dma PIO mode and without GPIO card_detect/write_protect
> > > option because of dependencies on EDMA and GPIO module DT support.
> > >
> > > Signed-off-by: Manjunathappa, Prakash <prakash.pm@ti.com>
> > > Cc: linux-mmc@vger.kernel.org
> > > Cc: linux-arm-kernel@lists.infradead.org
> > > Cc: linux-kernel@vger.kernel.org
> > > Cc: davinci-linux-open-source@linux.davincidsp.com
> > > Cc: devicetree-discuss@lists.ozlabs.org
> > > Cc: cjb@laptop.org
> > > Cc: Sekhar Nori <nsekhar@ti.com>
> > > Cc: mporter@ti.com
> > > ---
> > > Since v1:
> > > Modified DT parse function to take default values and accomodate controller
> > > version in compatible field.
> > >
> > > .../devicetree/bindings/mmc/davinci_mmc.txt | 30 ++++++++
> > > drivers/mmc/host/davinci_mmc.c | 70 +++++++++++++++++++-
> > > 2 files changed, 99 insertions(+), 1 deletions(-)
> > > create mode 100644 Documentation/devicetree/bindings/mmc/davinci_mmc.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/mmc/davinci_mmc.txt b/Documentation/devicetree/bindings/mmc/davinci_mmc.txt
> > > new file mode 100644
> > > index 0000000..6717ab1
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/mmc/davinci_mmc.txt
> > > @@ -0,0 +1,30 @@
> > > +* TI Highspeed MMC host controller for DaVinci
> > > +
> > > +The Highspeed MMC Host Controller on TI DaVinci family
> > > +provides an interface for MMC, SD and SDIO types of memory cards.
> > > +
> > > +This file documents the properties used by the davinci_mmc driver.
> > > +
> > > +Required properties:
> > > +- compatible:
> > > + Should be "ti,davinci-mmc-da830": for da830, da850, dm365
> > > + Should be "ti,davinci-mmc-dm355": for dm355, dm644x
> > > +
> > > +Optional properties:
> > > +- bus-width: Number of data lines, can be <4>, or <8>, default <1>
> > > +- max-frequency: Maximum operating clock frequency, default 25MHz.
> > > +- mmc-cap-mmc-highspeed: Indicates support for MMC in high speed mode
> > > +- mmc-cap-sd-highspeed: Indicates support for SD in high speed mode
> >
> > I thought the last two were derivable from max-frequency?
> >
>
> Yes, but I see below comment that it doesnot support MMC/SD.
> arch/arm/mach-davinci/devices.c: davinci_setup_mmc
> "
> * FIXME dm6441 (no MMC/SD), dm357 (one), and dm335 (two) are
> * not handled right here ...
> */"
> I was wondering how do we support such platforms, so I thought it is necessary
> to have these. But I see that on da850-evm even on skipping above flags EVM is able
> to detect card, does it mean there is no way to specify "no SD/MMC" capability?
> I will remove these and decide highspeed capability based on max-frequency.
>
Since this comment also applies for existing non-DT driver, I will plan to take
up activity later. For now I will submit next version of DT support patch
excluding highspeed card capability.
Thanks,
Prakash
[...]
next prev parent reply other threads:[~2013-02-11 5:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1360223825-23929-1-git-send-email-prakash.pm@ti.com>
2013-02-07 7:57 ` [PATCH v2 1/3] ARM: davinci: da850: override mmc DT node device name Manjunathappa, Prakash
2013-02-12 5:46 ` Sekhar Nori
2013-02-12 6:20 ` Manjunathappa, Prakash
2013-02-07 7:57 ` [PATCH v2 2/3] mmc: davinci_mmc: add DT support Manjunathappa, Prakash
2013-02-07 10:46 ` Mark Rutland
2013-02-08 6:25 ` Manjunathappa, Prakash
2013-02-08 9:37 ` Mark Rutland
2013-02-08 10:04 ` Manjunathappa, Prakash
2013-02-11 5:31 ` Manjunathappa, Prakash [this message]
2013-02-12 6:21 ` Sekhar Nori
2013-02-14 6:19 ` Manjunathappa, Prakash
2013-02-07 7:57 ` [PATCH v2 3/3] ARM: davinci: da850: add mmc DT entries Manjunathappa, Prakash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A73F36158E33644199EB82C5EC81C7BC3EA46794@DBDE01.ent.ti.com \
--to=prakash.pm@ti.com \
--cc=cjb@laptop.org \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=hs@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mporter@ti.com \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).