From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85D5CECDFB1 for ; Fri, 13 Jul 2018 18:56:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 410BC2084A for ; Fri, 13 Jul 2018 18:56:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 410BC2084A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731969AbeGMTM1 (ORCPT ); Fri, 13 Jul 2018 15:12:27 -0400 Received: from mga17.intel.com ([192.55.52.151]:23625 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729982AbeGMTM1 (ORCPT ); Fri, 13 Jul 2018 15:12:27 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jul 2018 11:56:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,348,1526367600"; d="asc'?scan'208";a="72157679" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by fmsmga001.fm.intel.com with ESMTP; 13 Jul 2018 11:56:22 -0700 Received: from orsmsx101.amr.corp.intel.com ([169.254.8.64]) by ORSMSX104.amr.corp.intel.com ([169.254.4.198]) with mapi id 14.03.0319.002; Fri, 13 Jul 2018 11:56:20 -0700 From: "Rustad, Mark D" To: Greg Kroah-Hartman CC: Dominique Martinet , Kalle Valo , "David S. Miller" , "Thomas Gleixner" , Kate Stewart , Philippe Ombredanne , Joe Perches , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 11/18] wireless/ti: change strncpy+truncation to strlcpy Thread-Topic: [PATCH 11/18] wireless/ti: change strncpy+truncation to strlcpy Thread-Index: AQHUGkiQnSqrSBIV50Cs5pYgepH/BqSNOawAgAC9eYA= Date: Fri, 13 Jul 2018 18:56:19 +0000 Message-ID: References: <1531444483-17338-1-git-send-email-asmadeus@codewreck.org> <1531445149-19607-1-git-send-email-asmadeus@codewreck.org> <20180713073810.GA31984@kroah.com> In-Reply-To: <20180713073810.GA31984@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-originating-ip: [10.233.89.158] Content-Type: multipart/signed; boundary="Apple-Mail=_62A240EE-15E3-4444-8FB8-33F20EB1E3A5"; protocol="application/pgp-signature"; micalg=pgp-sha256 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Apple-Mail=_62A240EE-15E3-4444-8FB8-33F20EB1E3A5 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii; delsp=yes; format=flowed On Jul 13, 2018, at 12:38 AM, Greg Kroah-Hartman wrote: > On Fri, Jul 13, 2018 at 03:25:49AM +0200, Dominique Martinet wrote: >> Generated by scripts/coccinelle/misc/strncpy_truncation.cocci >> >> Signed-off-by: Dominique Martinet > > I don't know about other maintainers, but I know I wouldn't take such a > horrid changelog description as this :) > > good luck! > > greg k-h I would be very concerned about the potential for information leak, because of the different behavior of the two functions. -- Mark Rustad, Networking Division, Intel Corporation --Apple-Mail=_62A240EE-15E3-4444-8FB8-33F20EB1E3A5 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="signature.asc" Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org iQIzBAEBCAAdFiEE6ug8b0Wg+ULmnksNPA7/547j7m4FAltI9dMACgkQPA7/547j 7m64Zg/8CFcXHIiBzkycbd1zbXM/fg17P97FUfJrf8njPSq9tInrpqI94Y7dm/9V j7Et8OgHuCV/VTz0LHf5ixZa//U4QQ4ODitHdZpZfXt4dDfT8g+hrAfnI9F9dsBl g9XErnZ4GQgbk/oS6uHGhOlUEo9J+KHLb+1LH4YFF7pOSe1fwCB+jLQQ3bmZStzi fousYPLvyIlueGPWpuZy7KN1dpvIDOFXYp/W2VuzHXLFzXjmcqSW9oGL/e+hBhEf ruoPkfOTRqlvysf4ke4PAco7k0QNrhcahX0slsqk1zfikuQu4pGvEvFUhHbOTsl3 kTv6BkxZhSDs8fXEgJn5J4nq0iarijf2aQW8xIFd/+fZeijWGguUVjAqj+JyE6yG V0NQvdUTuu/rL+zYayDIVaFyU+17A2q/INQUd5dclqXlDWd8uzmyY1btsS0fj71Y BBaRAPtXSFAyJfsSWNvRn4gBe+sdi66agSnuQF423pxBE+ew3PT3ubRzqo3VeuLv ejuC7m933VP8MFCBqgvDXdbtx/OcTrjjQLSHqRkqbBEu4p52PE9GxXHor/46mA+B PEFlkjmA5vx6fQh55KVY6kgPmNtS6e38ayktqp0s4P9dmVlzB1q0zrl7oIn0wlnQ Me7zM/4nkFI6ljhvkyeMjcXHPz5WLh+fEMG+i/XnRl5fecO0a2A= =JOCA -----END PGP SIGNATURE----- --Apple-Mail=_62A240EE-15E3-4444-8FB8-33F20EB1E3A5--