From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F15B7C49ED7 for ; Fri, 20 Sep 2019 06:58:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C42BC206C2 for ; Fri, 20 Sep 2019 06:58:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cA+ud2rC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394943AbfITG6w (ORCPT ); Fri, 20 Sep 2019 02:58:52 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:34832 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388940AbfITG6w (ORCPT ); Fri, 20 Sep 2019 02:58:52 -0400 Received: by mail-wm1-f66.google.com with SMTP id y21so1095077wmi.0 for ; Thu, 19 Sep 2019 23:58:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=yoSKv6iKPafqA3E2EdHP7bvoi3Wx6UArkcBIy3W3JgE=; b=cA+ud2rCE++WSHjLDz3AhrKm293GXSXkrwLk/s9r9iW4WBQtPmAPmvIByyMA9hh1VE ug54X6TIvCVMpSwKL/UF4ne11znZGpabGzgJd38sgYHeOHcP0/2tI2pKcuG4RMOFCpWL WXvdIzHkgfs83ngR0qoFEaQWT9jsT7EpNeCgUq6NtK+pK3hQCaFsuTU0gFmgEHlV/xz8 uTE3pJzqyTC43dkjHllvIP7kco+gOSyIEFSD0+jDyqob2BoR9aMvCmvLE/BbOHNV/7Em o/QaogW/g3+Zt8xN2m1Et005rX98nd7opXkYqFNlJe1tkomlr7Oyi+mPBQBco6Acxvvf NyrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=yoSKv6iKPafqA3E2EdHP7bvoi3Wx6UArkcBIy3W3JgE=; b=ZTPp1aHR80UHLYJ8SeCJxqgXhYmEBTT156pjw0h/eVgUzZlGh+RcRHgfsOj5HkQZ2y iEJdmGGe5LrOS4IenvIqXqhzpxLgvEFKSrNMcl4Cx7g1svGOJaf5ZnAztKId6I5PbxPq nFnIoxrhd2wu6Kd5lQJpr/np4gxejtPRAY1GWW5MIqpZfm2uj8jBqNRgfrGiEkLnuAbw iIDkwjjNYj6Wlth1IdNICMl4MGdJTP1glH803xSU5LUD/5M0kkOSiFJP+feDFDJx9ogm 00zuMY/7exSC3jlzEbZjvI3DoeFyeCCiyyLDZsEBhRC/sAa0QsV9QoH8w44RN/pI0fVd tJdg== X-Gm-Message-State: APjAAAXegRhNyKujuqqSlrdq3XReEmwpVCggHz/62XU0G7z5nMknhSix FGUqBb0NjBzPy3kxM29TBTfzvw== X-Google-Smtp-Source: APXvYqxFbquKMMhkFejMJOJKNJxEm+G04tfs3QH4DRcTuXri0pbUEPHrXRiB90Cn6nrpvSihy6vgcA== X-Received: by 2002:a1c:f009:: with SMTP id a9mr2017817wmb.151.1568962730219; Thu, 19 Sep 2019 23:58:50 -0700 (PDT) Received: from [192.168.0.100] (146-241-67-0.dyn.eolo.it. [146.241.67.0]) by smtp.gmail.com with ESMTPSA id b5sm817428wmj.18.2019.09.19.23.58.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Sep 2019 23:58:49 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Subject: Re: [PATCH 2/2] block, bfq: delete "bfq" prefix from cgroup filenames From: Paolo Valente In-Reply-To: <4F416823-855F-4091-90B9-92253BF189FA@linaro.org> Date: Fri, 20 Sep 2019 08:58:47 +0200 Cc: Jens Axboe , linux-block , linux-kernel , Ulf Hansson , Linus Walleij , noreply-spamdigest via bfq-iosched , Oleksandr Natalenko , cgroups@vger.kernel.org, Angelo Ruocco Content-Transfer-Encoding: quoted-printable Message-Id: References: <20190917165148.19146-1-paolo.valente@linaro.org> <20190917165148.19146-3-paolo.valente@linaro.org> <20190917213209.GK3084169@devbig004.ftw2.facebook.com> <4D39D2FA-A487-4FAD-A67E-B90750CE0BD4@linaro.org> <20190918151948.GL3084169@devbig004.ftw2.facebook.com> <4F416823-855F-4091-90B9-92253BF189FA@linaro.org> To: Tejun Heo X-Mailer: Apple Mail (2.3445.104.8) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Il giorno 18 set 2019, alle ore 18:19, Paolo Valente = ha scritto: >=20 >=20 >=20 >> Il giorno 18 set 2019, alle ore 17:19, Tejun Heo ha = scritto: >>=20 >> Hello, >>=20 >> On Wed, Sep 18, 2019 at 07:18:50AM +0200, Paolo Valente wrote: >>> A solution that both fulfills userspace request and doesn't break >>> anything for hypothetical users of the current interface already = made >>> it to mainline, and Linus liked it too. It is: >>=20 >> Linus didn't like it. The implementation was a bit nasty. That was >> why it became a subject in the first place. >>=20 >>> 19e9da9e86c4 ("block, bfq: add weight symlink to the bfq.weight = cgroup parameter") >>>=20 >>> But it was then reverted on Tejun's request to do exactly what we >>> don't want do any longer now: >>> cf8929885de3 ("cgroup/bfq: revert bfq.weight symlink change") >>=20 >> Note that the interface was wrong at the time too. >>=20 >>> So, Jens, Tejun, can we please just revert that revert? >>=20 >> I think presenting both io.weight and io.bfq.weight interfaces are >> probably the best course of action at this point but why does it have >> to be a symlink? What's wrong with just creating another file with >> the same backing function? >>=20 >=20 > I think a symlink would be much clearer for users, given the confusion > already caused by two names for the same parameter. But let's hear > others' opinion too. >=20 Jens, could you express your opinion on this? Any solution you and Tejun agree on is ok for me. Also this new (fourth) possible implementation of this fix, provided that then it is definitely ok for both of you. Thanks, Paolo > Thanks, > Paolo >=20 >> Thanks. >>=20 >> --=20 >> tejun