From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 191D9C3F2D7 for ; Wed, 4 Mar 2020 16:02:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E8C9F2166E for ; Wed, 4 Mar 2020 16:02:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729810AbgCDQCy convert rfc822-to-8bit (ORCPT ); Wed, 4 Mar 2020 11:02:54 -0500 Received: from coyote.holtmann.net ([212.227.132.17]:55886 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726263AbgCDQCx (ORCPT ); Wed, 4 Mar 2020 11:02:53 -0500 Received: from marcel-macpro.fritz.box (p4FEFC5A7.dip0.t-ipconnect.de [79.239.197.167]) by mail.holtmann.org (Postfix) with ESMTPSA id 73B6ECECDF; Wed, 4 Mar 2020 17:12:19 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\)) Subject: Re: [PATCH v1] Bluetooth: hci_qca: Replace devm_gpiod_get() with devm_gpiod_get_optional() From: Marcel Holtmann In-Reply-To: <20200304131645.22057-1-rjliao@codeaurora.org> Date: Wed, 4 Mar 2020 17:02:51 +0100 Cc: Johan Hedberg , linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-arm-msm@vger.kernel.org, bgodavar@codeaurora.org, c-hbandi@codeaurora.org, hemantg@codeaurora.org, mka@chromium.org Content-Transfer-Encoding: 8BIT Message-Id: References: <20200304131645.22057-1-rjliao@codeaurora.org> To: Rocky Liao X-Mailer: Apple Mail (2.3608.60.0.2.5) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rocky, > This patch replaces devm_gpiod_get() with devm_gpiod_get_optional() to get > bt_en and replaces devm_clk_get() with devm_clk_get_optional() to get > susclk. It also uses NULL check to determine whether the resource is > available or not. > > Fixes: 8a208b24d770 ("Bluetooth: hci_qca: Make bt_en and susclk not mandatory for QCA Rome") > Signed-off-by: Rocky Liao > --- > drivers/bluetooth/hci_qca.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel