From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754163Ab0IWJEe (ORCPT <rfc822;w@1wt.eu>);
	Thu, 23 Sep 2010 05:04:34 -0400
Received: from mail-qw0-f46.google.com ([209.85.216.46]:50001 "EHLO
	mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752470Ab0IWJEc convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 23 Sep 2010 05:04:32 -0400
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=MCNeOlhSy9NZwG1k0ZhZ3nVIwBrAtEBjWZaJtC4dyWLzbOdOEzA5brVWvyXkPCKHlN
         8P1qrd+E7Yzic8jIUmGQ+IcBMjecnKlOqXtIXNtgE1GF4iF/r8HgSdOLF1LKYoYk7RY7
         6geG1kd7wNa6JoQ9HSQIN37JSiB5YN/f1aHjM=
MIME-Version: 1.0
In-Reply-To: <20100921124718.GE18991@one.firstfloor.org>
References: <1284865235-29920-1-git-send-email-ying.huang@intel.com>
	<1284865235-29920-6-git-send-email-ying.huang@intel.com>
	<20100921124718.GE18991@one.firstfloor.org>
Date: Thu, 23 Sep 2010 17:04:31 +0800
Message-ID: <AANLkTi=-LzZSgk9BYg8z6i5QrbRWPVBYtpqdkvsTc_E_@mail.gmail.com>
Subject: Re: [PATCH 5/5] ACPI, APEI, Fix ERST MOVE_DATA instruction implementation
From: huang ying <huang.ying.caritas@gmail.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Huang Ying <ying.huang@intel.com>, Len Brown <lenb@kernel.org>,
        linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On Tue, Sep 21, 2010 at 8:47 PM, Andi Kleen <andi@firstfloor.org> wrote:
> On Sun, Sep 19, 2010 at 11:00:35AM +0800, Huang Ying wrote:
>> diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c
>> index 40b01c3..a103963 100644
>> --- a/drivers/acpi/apei/erst.c
>> +++ b/drivers/acpi/apei/erst.c
>> @@ -266,13 +266,27 @@ static int erst_exec_move_data(struct apei_exec_context *ctx,
>>  {
>>       int rc;
>>       u64 offset;
>> +     void *src, *dst;
>> +
>> +     /* ioremap does not work in interrupt context */
>> +     if (in_interrupt())
>> +             return -EBUSY;
>
> That breaks serialization of machine checks no? If the BIOS uses MOVE_DATA
> How about using kmap_atomic instead?

In my test machine, MOVE_DATA is not used. So this does not breaks
serialization of machine checks.

We can not use kmap_atomic or kmap_atomic_pfn here. Because
kmap_atomic_xxx needs struct page, but the address provided by BIOS
may be in E820_RESERVED area, that is, the corresponding page may have
no struct page. Maybe we need another kmap_atomic implementation for
E820_RESERVED area.

Best Regards,
Huang Ying