From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751586Ab1CTJCQ (ORCPT ); Sun, 20 Mar 2011 05:02:16 -0400 Received: from mail-yi0-f46.google.com ([209.85.218.46]:58055 "EHLO mail-yi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751600Ab1CTJCL (ORCPT ); Sun, 20 Mar 2011 05:02:11 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=HoTnGvLTakZ6CRuo/eQ93JQ6VuT4xGaWwhSlwfvJrUNDxfwRDze8kNCy4QFOWQlpuT wwtqkymXEfBCgw+Gwhb7TvQXMNag49J2ev32+xSDXeZrR6FY9qObVGir9etuA9iOjw6A Jr1yta5dZ4NSse6wR6YBwetIMJCC1cqtPmczY= MIME-Version: 1.0 In-Reply-To: References: <1300416744.16880.904.camel@gandalf.stny.rr.com> <20110317211548.646b04d2@tpl.lwn.net> <1300419170.16880.956.camel@gandalf.stny.rr.com> Date: Sun, 20 Mar 2011 11:02:10 +0200 X-Google-Sender-Auth: Blt-gZngvKYMGajO5zEQVGlNT6Q Message-ID: Subject: Re: [PATCH] checkpatch: Test for kmalloc/memset(0) pairs From: Pekka Enberg To: Julia Lawall Cc: =?ISO-8859-1?Q?Am=E9rico_Wang?= , Steven Rostedt , Jonathan Corbet , LKML , Andy Whitcroft , Dave Jones , Andrew Morton , Nicolas Palix , Ingo Molnar Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Julia, On Sun, Mar 20, 2011 at 10:01 AM, Julia Lawall wrote: > Suggestions for how to make it easier to use or the documentation more > understandable are welcome. The benefit of scripts/checkpatch.pl is that it doesn't require any setting up to do. I'm personally less likely to use Coccinelle (and Sparse for that matter) on boxes where the software is not installed. I'm not sure how other people feel about it, but I'd personally love to see tools/coccinelle and tools/sparse. As for something more concrete, I guess this is what I'm mostly interested in: penberg@jaguar:~/src/linux$ make C=1 CHECK="scripts/coccicheck" mm/slub.o I guess it'd be good to document that for 'make help' because now you need to dig through Documentation/coccinelle.txt to find it. P.S. It seems there's a bug somewhere because the above command fails miserably for me: CHK include/linux/version.h CHK include/generated/utsrelease.h CALL scripts/checksyscalls.sh CHECK mm/slub.c File "/home/penberg/src/linux/scripts/coccinelle/api/memdup_user.cocci", line 32, column 5, charpos = 747 around = '<+...', whole content = - <+... when != goto l2; Fatal error: exception Lexer_cocci.Lexical("invalid in a nonempty context: <+...") File "/home/penberg/src/linux/scripts/coccinelle/api/memdup_user.cocci", line 32, column 5, charpos = 747 around = '<+...', whole content = - <+... when != goto l2; Fatal error: exception Lexer_cocci.Lexical("invalid in a nonempty context: <+...") File "/home/penberg/src/linux/scripts/coccinelle/api/memdup_user.cocci", line 32, column 5, charpos = 747 around = '<+...', whole content = - <+... when != goto l2; Fatal error: exception Lexer_cocci.Lexical("invalid in a nonempty context: <+...") File "/home/penberg/src/linux/scripts/coccinelle/api/memdup_user.cocci", line 32, column 5, charpos = 747 around = '<+...', whole content = - <+... when != goto l2; Fatal error: exception Lexer_cocci.Lexical("invalid in a nonempty context: <+...") make[1]: *** [mm/slub.o] Error 1 make: *** [mm/slub.o] Error 2 penberg@jaguar:~/src/linux$ dpkg -l|grep coccinelle ii coccinelle 0.2.2.deb-2 semantic patching tool for C [ I'm on Ubuntu 10.10. ] Pekka