From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755581Ab1CXNrP (ORCPT ); Thu, 24 Mar 2011 09:47:15 -0400 Received: from mail-iw0-f174.google.com ([209.85.214.174]:61018 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751876Ab1CXNrN convert rfc822-to-8bit (ORCPT ); Thu, 24 Mar 2011 09:47:13 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; b=q/3zJOdhTDYKUhJfMPBGGAW5b564X9JsiU2kPop0VHy9o5ps9FRSs43I8cNX1+udp7 1ttc1HVBmWe77IF/5evA9Vew5Be+j3GyY1kO4QOmbvW+7182D1puwekZWQI4i0EOEWbb zj+Kgb5FdASdHAbIk3Vg6GSmT/rU7Xb2wekzQ= MIME-Version: 1.0 In-Reply-To: <20110324085112.GB12038@htj.dyndns.org> References: <4CC69B22.2050708@kernel.org> <20101025224111.7798.38960.stgit@warthog.procyon.org.uk> <12101.1288088542@redhat.com> <4CC6C62F.1000804@kernel.org> <4CC6C941.2080003@kernel.org> <4CC6CD4D.3010501@kernel.org> <4CC6E05A.8040508@kernel.org> <20110324082523.GA12038@htj.dyndns.org> <20110324085112.GB12038@htj.dyndns.org> From: Mike Frysinger Date: Thu, 24 Mar 2011 09:46:53 -0400 X-Google-Sender-Auth: AFkLM5Q6SXGG9GI91ietb6uUCiM Message-ID: Subject: Re: [Uclinux-dist-devel] [RFC PATCH] percpu: always align percpu output section to PAGE_SIZE To: Tejun Heo Cc: torvalds@osdl.org, Alexander van Heukelum , linux-am33-list@redhat.com, user-mode-linux-devel@lists.sourceforge.net, Jeff Dike , linux-kernel@vger.kernel.org, David Howells , Mark Salter , uclinux-dist-devel@blackfin.uclinux.org, akpm@linux-foundation.org, Ingo Molnar , Akira Takeuchi Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 24, 2011 at 4:51 AM, Tejun Heo wrote: > On Thu, Mar 24, 2011 at 09:25:23AM +0100, Tejun Heo wrote: >> On Thu, Mar 24, 2011 at 02:46:01AM -0400, Mike Frysinger wrote: >> > On Tue, Oct 26, 2010 at 10:06, Tejun Heo wrote: >> > > The linker script macros PERCPU_VADDR() and PERCPU() are used to >> > > define this output section and the latter takes @align parameter. >> > > Several architectures are using @align smaller than PAGE_SIZE breaking >> > > percpu memory alignment. >> > >> > hmm, i just pushed through a fix in the Blackfin tree as we hit a boot >> > failure otherwise: >> > -   PERCPU(4) >> > +   PERCPU(PAGE_SIZE) >> > >> > > This patch removes @align parameter from PERCPU(), renames it to >> > > PERCPU_SECTION and makes it always align to PAGE_SIZE.  While at it, >> > > add PCPU_SETUP_BUG_ON() checks such that alignment problems are >> > > reliably detected and remove percpu alignment comment recently added >> > > in workqueue.c as the condition would trigger BUG way before reaching >> > > there. >> > >> > seems this still hasnt made it to mainline.  has it stalled or >> > something ?  feel free for the Blackfin bits: >> > Signed-off-by: Mike Frysinger >> >> Heh, I just forgot.  I'll queue it with your Acked-by added. > > BTW, you're gonna push out the blackfin change to mainline soon, > right?  I'll queue the patch for the next merge window once the > blackfin fix hits mainline. Linus has already pulled it -mike