From: Minchan Kim <minchan.kim@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Ben Gamari <bgamari.foss@gmail.com>,
linux-kernel@vger.kernel.org, rsync@lists.samba.org,
linux-mm@kvack.org, Wu Fengguang <fengguang.wu@intel.com>,
Rik van Riel <riel@redhat.com>
Subject: Re: fadvise DONTNEED implementation (or lack thereof)
Date: Mon, 15 Nov 2010 18:05:00 +0900 [thread overview]
Message-ID: <AANLkTikibS1fDuk67RHk4SU14pJ9nPdodWba1T3Z_pWE@mail.gmail.com> (raw)
In-Reply-To: <1289810825.2109.469.camel@laptop>
On Mon, Nov 15, 2010 at 5:47 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Mon, 2010-11-15 at 15:07 +0900, Minchan Kim wrote:
>> On Sun, Nov 14, 2010 at 2:09 PM, KOSAKI Motohiro
>> <kosaki.motohiro@jp.fujitsu.com> wrote:
>> >> On Tue, 9 Nov 2010 16:28:02 +0900 (JST), KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
>> >> > So, I don't think application developers will use fadvise() aggressively
>> >> > because we don't have a cross platform agreement of a fadvice behavior.
>> >> >
>> >> I strongly disagree. For a long time I have been trying to resolve
>> >> interactivity issues caused by my rsync-based backup script. Many kernel
>> >> developers have said that there is nothing the kernel can do without
>> >> more information from user-space (e.g. cgroups, madvise). While cgroups
>> >> help, the fix is round-about at best and requires configuration where
>> >> really none should be necessary. The easiest solution for everyone
>> >> involved would be for rsync to use FADV_DONTNEED. The behavior doesn't
>> >> need to be perfectly consistent between platforms for the flag to be
>> >> useful so long as each implementation does something sane to help
>> >> use-once access patterns.
>> >>
>> >> People seem to mention frequently that there are no users of
>> >> FADV_DONTNEED and therefore we don't need to implement it. It seems like
>> >> this is ignoring an obvious catch-22. Currently rsync has no fadvise
>> >> support at all, since using[1] the implemented hints to get the desired
>> >> effect is far too complicated^M^M^M^Mhacky to be considered
>> >> merge-worthy. Considering the number of Google hits returned for
>> >> fadvise, I wouldn't be surprised if there were countless other projects
>> >> with this same difficulty. We want to be able to tell the kernel about
>> >> our useage patterns, but the kernel won't listen.
>> >
>> > Because we have an alternative solution already. please try memcgroup :)
>
> Using memcgroup for this is utter crap, it just contains the trainwreck,
> it doesn't solve it in any way.
>
>> I think memcg could be a solution of them but fundamental solution is
>> that we have to cure it in VM itself.
>> I feel it's absolutely absurd to enable and use memcg for amending it.
>
> Agreed..
>
>> I wonder what's the problem in Peter's patch 'drop behind'.
>> http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg179576.html
>>
>> Could anyone tell me why it can't accept upstream?
>
> Read the thread, its quite clear nobody got convinced it was a good idea
> and wanted to fix the use-once policy, then Rik rewrote all of
> page-reclaim.
>
Thanks for the information.
I hope this is a chance to rethink about it.
Rik, Could you give us to any comment about this idea?
--
Kind regards,
Minchan Kim
next prev parent reply other threads:[~2010-11-15 9:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-04 5:58 fadvise DONTNEED implementation (or lack thereof) Ben Gamari
2010-11-09 7:28 ` KOSAKI Motohiro
2010-11-09 8:03 ` KOSAKI Motohiro
2010-11-09 12:54 ` Ben Gamari
2010-11-14 5:09 ` KOSAKI Motohiro
2010-11-14 5:20 ` Ben Gamari
2010-11-14 21:33 ` Brian K. White
2010-11-15 6:07 ` Minchan Kim
2010-11-15 7:09 ` KOSAKI Motohiro
2010-11-15 7:19 ` Minchan Kim
2010-11-15 7:28 ` KOSAKI Motohiro
2010-11-15 7:46 ` Minchan Kim
2010-11-15 12:46 ` Ben Gamari
2010-11-15 8:47 ` Peter Zijlstra
2010-11-15 9:05 ` Minchan Kim [this message]
2010-11-15 14:48 ` Rik van Riel
2010-11-17 10:16 ` Minchan Kim
2010-11-17 11:15 ` Minchan Kim
2010-11-17 16:22 ` Rik van Riel
2010-11-18 2:47 ` Minchan Kim
2010-11-18 3:24 ` Rik van Riel
2010-11-18 3:46 ` Minchan Kim
2010-11-15 9:10 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikibS1fDuk67RHk4SU14pJ9nPdodWba1T3Z_pWE@mail.gmail.com \
--to=minchan.kim@gmail.com \
--cc=bgamari.foss@gmail.com \
--cc=fengguang.wu@intel.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=rsync@lists.samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).