From: Ivo Clarysse <ivo.clarysse@gmail.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: Sascha Hauer <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv3 4/5] mtd: mxc_nand fixups
Date: Fri, 25 Jun 2010 16:50:45 +0200 [thread overview]
Message-ID: <AANLkTilTbvlPxRhioMiKrBUNggcxZeboi1YpB8Y9Bdpm@mail.gmail.com> (raw)
In-Reply-To: <807hloag6w.fsf@merkur.tec.linutronix.de>
On Thu, Jun 24, 2010 at 12:16 PM, John Ogness <john.ogness@linutronix.de> wrote:
> On 2010-06-24, Sascha Hauer <s.hauer@pengutronix.de> wrote:
>> Ok, if it's the only way out to have 5 cpu_is_* blocks, then lets go
>> for it.
>
> Here is a new patch that puts the behavior behind a "nfc_avoid_masking"
> macro. The macro is only used 3 times.
[...]
Tested on an MX21ADS board, and it still works.
> This patch is based on linux-next 20100618.
>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
> ---
> drivers/mtd/nand/mxc_nand.c | 81 +++++++++++++++++++++++++---------
> 1 file changed, 61 insertions(+), 20 deletions(-)
>
> Index: linux-next-20100618/drivers/mtd/nand/mxc_nand.c
> ===================================================================
> --- linux-next-20100618.orig/drivers/mtd/nand/mxc_nand.c
> +++ linux-next-20100618/drivers/mtd/nand/mxc_nand.c
[...]
> @@ -100,6 +109,18 @@
>
> #define NFC_RSLTSPARE_AREA_MASK 0xff
>
> +#define nfc_interrupt_set(_regs) \
> + (readw(_regs + NFC_CONFIG2) & NFC_INT)
> +#define nfc_clear_interrupt(_regs) \
> + writew(readw(_regs + NFC_CONFIG2) & ~NFC_INT, \
> + _regs + NFC_CONFIG2)
Naming is not very consistent; I'd suggest nfc_set_interrupt /
nfc_clear_interrupt
> +#define nfc_mask_irq(_regs) \
> + writew(readw(_regs + NFC_CONFIG1) | NFC_INT_MSK, \
> + _regs + NFC_CONFIG1)
> +#define nfc_unmask_irq(_regs) \
> + writew(readw(_regs + NFC_CONFIG1) & ~NFC_INT_MSK, \
> + _regs + NFC_CONFIG1)
> +
[...]
next prev parent reply other threads:[~2010-06-25 14:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-18 17:01 [PATCH 4/5] mtd: mxc_nand fixups John Ogness
2010-06-18 20:54 ` Sascha Hauer
2010-06-19 20:25 ` John Ogness
[not found] ` <AANLkTimA7Rbm_nHpVYpEPqaPCjrOse9s8YyiInWlhfEK@mail.gmail.com>
2010-06-20 9:21 ` [PATCHv2 " John Ogness
2010-06-21 11:47 ` Ivo Clarysse
2010-06-22 15:54 ` [PATCHv3 " John Ogness
2010-06-23 7:34 ` Ivo Clarysse
2010-06-23 8:48 ` John Ogness
2010-06-23 9:23 ` Ivo Clarysse
2010-06-23 10:10 ` John Ogness
2010-06-24 7:27 ` Sascha Hauer
2010-06-24 10:16 ` John Ogness
2010-06-25 14:50 ` Ivo Clarysse [this message]
2010-06-26 9:17 ` John Ogness
2010-07-01 14:24 ` Ivo Clarysse
2010-06-25 14:46 ` Ivo Clarysse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTilTbvlPxRhioMiKrBUNggcxZeboi1YpB8Y9Bdpm@mail.gmail.com \
--to=ivo.clarysse@gmail.com \
--cc=john.ogness@linutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).