From: Audun Hoem <audun.hoem@gmail.com>
To: Florian Mickler <florian@mickler.org>
Cc: Andy Whitcroft <apw@canonical.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] checkpatch.pl: fix CAST detection to not screw with parens handling
Date: Wed, 3 Nov 2010 16:26:44 +0100 [thread overview]
Message-ID: <AANLkTim=L_J4BF9Zxkzqme-Rj77-MTiT0mGR5hp+t0xW@mail.gmail.com> (raw)
In-Reply-To: <20101103162042.297958c3@schatten.dmk.lab>
On 11/3/10, Florian Mickler <florian@mickler.org> wrote:
> On Wed, 3 Nov 2010 13:04:33 +0100
> Florian Mickler <florian@mickler.org> wrote:
>
>> Casts have to be handled after the last type that is followed by an
>> opening parenthesis is handled.
>
> That is the wrong fix. I realized now that with that patch we would
> not claim anything as a CAST anymore. Better is probably to only claim
> a CAST if av_pending is not set. Andy, would that work? It seems to be
> alright... Do you have some tests for checkpatch?
>
> Testing it with the reported line and some other random samples it
> seems to be alright.
>
Probably good enough of a test to try it on random kernel code.
next prev parent reply other threads:[~2010-11-03 15:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-02 22:57 Bug in checkpatch.pl Audun Hoem
2010-11-03 12:04 ` [PATCH] checkpatch.pl: fix CAST detection to not screw with parens handling Florian Mickler
2010-11-03 15:20 ` Florian Mickler
2010-11-03 15:26 ` Audun Hoem [this message]
2010-11-03 16:07 ` Florian Mickler
2010-11-17 7:30 ` Florian Mickler
2010-11-23 14:15 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTim=L_J4BF9Zxkzqme-Rj77-MTiT0mGR5hp+t0xW@mail.gmail.com' \
--to=audun.hoem@gmail.com \
--cc=apw@canonical.com \
--cc=florian@mickler.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).