linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Zhao <linuxzsc@gmail.com>
To: Dinh.Nguyen@freescale.com
Cc: linux-kernel@vger.kernel.org, amit.kucheria@canonical.com,
	linux@arm.linux.org.uk, s.hauer@pengutronix.de, eric@eukrea.com,
	u.kleine-koenig@pengutronix.de,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv5 1/3] ARM: imx: Add core definitions for MX53
Date: Wed, 24 Nov 2010 21:20:26 +0800	[thread overview]
Message-ID: <AANLkTimN1tQee2PywyphPnAdvC8_ASgZud_F=ma_+Bde@mail.gmail.com> (raw)
In-Reply-To: <1289842201-3277-1-git-send-email-Dinh.Nguyen@freescale.com>

Hi Dinh,

> diff --git a/arch/arm/mach-mx5/crm_regs.h b/arch/arm/mach-mx5/crm_regs.h
> index c776b9a..51ff9bb 100644
> --- a/arch/arm/mach-mx5/crm_regs.h
> +++ b/arch/arm/mach-mx5/crm_regs.h
> @@ -18,6 +18,9 @@
>  #define MX51_CORTEXA8_BASE     MX51_IO_ADDRESS(MX51_ARM_BASE_ADDR)
>  #define MX51_GPC_BASE          MX51_IO_ADDRESS(MX51_GPC_BASE_ADDR)
>
> +/*MX53*/
> +#define MX53_DPLL4_BASE                MX53_IO_ADDRESS(MX53_PLL3_BASE_ADDR)
> +
>  /* PLL Register Offsets */
>  #define MXC_PLL_DP_CTL                 0x00
>  #define MXC_PLL_DP_CONFIG              0x04

CCM and PLL base address are different between mx53 and mx51. Why do
you both use mx51 base address?

Thanks
Richard

      parent reply	other threads:[~2010-11-24 13:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-15 17:29 [PATCHv5 1/3] ARM: imx: Add core definitions for MX53 Dinh.Nguyen
2010-11-15 17:30 ` [PATCHv5 2/3] ARM: imx: Add mx53 support to common msl functions Dinh.Nguyen
2010-11-15 17:30   ` [PATCHv5 3/3] ARM: imx: Get the silicon version from the IIM module Dinh.Nguyen
2010-11-24 13:20 ` Richard Zhao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTimN1tQee2PywyphPnAdvC8_ASgZud_F=ma_+Bde@mail.gmail.com' \
    --to=linuxzsc@gmail.com \
    --cc=Dinh.Nguyen@freescale.com \
    --cc=amit.kucheria@canonical.com \
    --cc=eric@eukrea.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=s.hauer@pengutronix.de \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).