linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: huang ying <huang.ying.caritas@gmail.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Huang Ying <ying.huang@intel.com>, Len Brown <lenb@kernel.org>,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	Jin Dongming <jin.dongming@np.css.fujitsu.com>
Subject: Re: [PATCH 3/5] ACPI, APEI, HEST Fix the unsuitable usage of platform_data
Date: Thu, 23 Sep 2010 17:06:34 +0800	[thread overview]
Message-ID: <AANLkTimrmFJE+7VQqRDe+3oj6XbsBTdfOn=B7Whj3dPS@mail.gmail.com> (raw)
In-Reply-To: <20100921124308.GC18991@one.firstfloor.org>

Hi, Andi,

On Tue, Sep 21, 2010 at 8:43 PM, Andi Kleen <andi@firstfloor.org> wrote:
> On Sun, Sep 19, 2010 at 11:00:33AM +0800, Huang Ying wrote:
>> diff --git a/drivers/acpi/apei/hest.c b/drivers/acpi/apei/hest.c
>> index 343168d..1a3508a 100644
>> --- a/drivers/acpi/apei/hest.c
>> +++ b/drivers/acpi/apei/hest.c
>> @@ -137,20 +137,23 @@ static int hest_parse_ghes_count(struct acpi_hest_header *hest_hdr, void *data)
>>
>>  static int hest_parse_ghes(struct acpi_hest_header *hest_hdr, void *data)
>
> hest_hdr is a local variable on the stack.
>
>
>> +
>> +     rc = platform_device_add_data(ghes_dev, &hest_hdr, sizeof(void *));
>> +     if (rc)
>> +             goto err;
>
> Now you put the address of that local variable in some global data structure.
>
> And then you likely return and later the access accesses random stack space?

platform_device_add_data will allocate some new memory, and copy
hest_hdr to there, so this is safe.

Best Regards,
Huang Ying

  parent reply	other threads:[~2010-09-23  9:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-19  3:00 [PATCH 0/5] ACPI, APEI, BUG fixes for 2.6.36 Huang Ying
2010-09-19  3:00 ` [PATCH 1/5] ACPI, APEI, Fix APEI related table size checking Huang Ying
2010-09-21 12:39   ` Andi Kleen
2010-09-26  5:30     ` Huang Ying
2010-09-19  3:00 ` [PATCH 2/5] ACPI, APEI, Fix acpi_pre_map() return value Huang Ying
2010-09-21 12:47   ` Andi Kleen
2010-09-19  3:00 ` [PATCH 3/5] ACPI, APEI, HEST Fix the unsuitable usage of platform_data Huang Ying
2010-09-21 12:43   ` Andi Kleen
2010-09-22  1:05     ` Jin Dongming
2010-09-23  9:06     ` huang ying [this message]
2010-09-19  3:00 ` [PATCH 4/5] ACPI, APEI, Fix error path for memory allocation Huang Ying
2010-09-21 12:45   ` Andi Kleen
2010-09-23  8:53     ` huang ying
2010-09-19  3:00 ` [PATCH 5/5] ACPI, APEI, Fix ERST MOVE_DATA instruction implementation Huang Ying
2010-09-21 12:47   ` Andi Kleen
2010-09-23  9:04     ` huang ying
2010-09-27  5:31       ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTimrmFJE+7VQqRDe+3oj6XbsBTdfOn=B7Whj3dPS@mail.gmail.com' \
    --to=huang.ying.caritas@gmail.com \
    --cc=andi@firstfloor.org \
    --cc=jin.dongming@np.css.fujitsu.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).