From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933058Ab0LTT00 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 20 Dec 2010 14:26:26 -0500
Received: from mail-wy0-f174.google.com ([74.125.82.174]:37589 "EHLO
	mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932994Ab0LTT0Y convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 20 Dec 2010 14:26:24 -0500
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=Iuqu21ivmYWFw8GfhAKQizCAe1a8huHNCoeBswWISX4rFKAtfVYoeVnhKsedKezGg0
         V17MgPy8DavdcLfIBgnJNKWZHL8BEHtdK+uNTBXyEdeITZMvS5wDJQsT9K9hunhsXZ2Q
         jA0ia0ZJMqleN3dyWeDi7kqeKClZRuI1ei9n8=
MIME-Version: 1.0
In-Reply-To: <20101220191549.GH28157@n2100.arm.linux.org.uk>
References: <1289147348-31969-1-git-send-email-alchark@gmail.com>
	<20101107165745.GB1759@n2100.arm.linux.org.uk>
	<AANLkTimFJ=Brx4pDiUqZOKDfABaDg0s_yFC7EkZGi7D8@mail.gmail.com>
	<20101107171726.GF1759@n2100.arm.linux.org.uk>
	<20101108171930.GA1471@alchark-u3s.lan>
	<20101111212322.GA15533@alchark-u3s.lan>
	<20101111234957.GA28735@n2100.arm.linux.org.uk>
	<20101219174017.GA31832@alchark-u3s>
	<20101220191549.GH28157@n2100.arm.linux.org.uk>
Date: Mon, 20 Dec 2010 22:26:22 +0300
Message-ID: <AANLkTin1UVtX9YgNrJwpwyoUcbbCU5aUsJ9p83_B2_gE@mail.gmail.com>
Subject: Re: [PATCH 1/6 v8] ARM: Add basic architecture support for
 VIA/WonderMedia 85xx SoC's
From: Alexey Charkov <alchark@gmail.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org,
        vt8500-wm8505-linux-kernel@googlegroups.com,
        Eric Miao <eric.y.miao@gmail.com>,
        =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= 
	<u.kleine-koenig@pengutronix.de>,
        Albin Tonnerre <albin.tonnerre@free-electrons.com>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

2010/12/20 Russell King - ARM Linux <linux@arm.linux.org.uk>:
> On Sun, Dec 19, 2010 at 08:40:17PM +0300, Alexey Charkov wrote:
>> +config ARCH_VT8500
>> +     bool "VIA/WonderMedia 85xx"
>> +     select CPU_ARM926T
>> +     select GENERIC_GPIO
>> +     select ARCH_HAS_CPUFREQ
>> +     select GENERIC_TIME
>
> Everything looks good, except for the above.  You don't need to select
> GENERIC_TIME - it doesn't exist anymore.

Ok, that was an old copy-paste. Will resubmit a revised version in a moment.

> It's also good to see that you've picked up on registering clocksources
> with the _hz/_khz functions.

Yes, these are quite handy. I will also check if my previously spotted
performance issues with sched_clock are relieved with the latest
clocksource-related instrumentary in 'devel': maybe it wasn't all due
to evil busy-waiting on counter-to-bus synchronization. However, that
would probably be worth a separate small patch.

Thanks,
Alexey