From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751961Ab1BGFdj (ORCPT ); Mon, 7 Feb 2011 00:33:39 -0500 Received: from na3sys009aog112.obsmtp.com ([74.125.149.207]:42826 "EHLO na3sys009aog112.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751365Ab1BGFdi convert rfc822-to-8bit (ORCPT ); Mon, 7 Feb 2011 00:33:38 -0500 MIME-Version: 1.0 In-Reply-To: <87zkqbjtrd.fsf@ti.com> References: <96a2b24548af3a68fde712c68b49e856e53ea1fc.1296818921.git.segoon@openwall.com> <87zkqbjtrd.fsf@ti.com> From: "Menon, Nishanth" Date: Mon, 7 Feb 2011 11:03:15 +0530 Message-ID: Subject: Re: [PATCH 03/20] mach-omap2: smartreflex: world-writable debugfs voltage files To: Kevin Hilman Cc: Vasiliy Kulikov , linux-kernel@vger.kernel.org, security@kernel.org, Tony Lindgren , Russell King , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 5, 2011 at 04:24, Kevin Hilman wrote: > Vasiliy Kulikov writes: > >> Don't allow everybody to change voltage settings. >> >> Signed-off-by: Vasiliy Kulikov >> --- >>  Cannot compile the driver, so it is not tested at all. > > Acked-by: Kevin Hilman Also fixes the checkpatch warning: scripts/checkpatch.pl -f arch/arm/mach-omap2/smartreflex.c WARNING: Exporting world writable files is usually an error. Consider more restrictive permissions. #903: FILE: arm/mach-omap2/smartreflex.c:903: + (void) debugfs_create_file("autocomp", S_IRUGO | S_IWUGO, dbg_dir, total: 0 errors, 1 warnings, 1028 lines checked Acked-by: Nishanth Menon Regards, Nishanth Menon