From: Linus Torvalds <torvalds@linux-foundation.org>
To: Latchesar Ionkov <lucho@ionkov.net>
Cc: "Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com>,
Eric Van Hensbergen <ericvh@gmail.com>,
V9FS Developers <v9fs-developer@lists.sourceforge.net>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [V9fs-developer] [GIT PULL] 9p file system bug fixes for 2.6.35-rc2
Date: Wed, 30 Jun 2010 11:31:38 -0700 [thread overview]
Message-ID: <AANLkTinVdrY7AHFCjDIWAD0yLGhLYZwwHH3kKXBlkD5v@mail.gmail.com> (raw)
In-Reply-To: <AANLkTimmEi-3WF3pMcXmKiyElG9O7QLHNImPN0eJ05D3@mail.gmail.com>
On Wed, Jun 30, 2010 at 11:16 AM, Latchesar Ionkov <lucho@ionkov.net> wrote:
>
> I think that you need to use the s_vfs_rename_mutex in the super_block
> struct instead of introducing a new rename_lock in the v9fs session.
I actually think it's better to avoid having filesystems muck around
with VFS locking details. Also, I think we get the VFS rename mutex
only for cross-directory renames, and as mentioned, 9p needs locking
even for regular directory renames.
(Also, this way you can have parallel readers - although we could
obviously change the vfs rename mutex into a rw-sem too).
So I do think that keeping the logic private to a 9p-specific lock is
the right solution here.
Linus
next prev parent reply other threads:[~2010-06-30 18:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-07 20:02 [GIT PULL] 9p file system bug fixes for 2.6.35-rc2 Eric Van Hensbergen
2010-06-08 0:08 ` Linus Torvalds
2010-06-08 0:41 ` Al Viro
2010-06-08 0:48 ` Linus Torvalds
2010-06-16 16:42 ` [V9fs-developer] " Aneesh Kumar K. V
2010-06-24 16:30 ` Aneesh Kumar K. V
2010-06-29 20:18 ` Eric Van Hensbergen
2010-06-29 20:38 ` Linus Torvalds
2010-06-30 11:52 ` Aneesh Kumar K. V
2010-06-30 16:48 ` Linus Torvalds
2010-06-30 18:58 ` Aneesh Kumar K. V
2010-06-30 18:16 ` Latchesar Ionkov
2010-06-30 18:31 ` Linus Torvalds [this message]
2010-06-30 18:33 ` Aneesh Kumar K. V
2010-06-30 12:55 ` Aneesh Kumar K. V
2010-06-08 14:29 ` Venkateswararao Jujjuri (JV)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinVdrY7AHFCjDIWAD0yLGhLYZwwHH3kKXBlkD5v@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=ericvh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).