From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752480Ab0KINCR (ORCPT ); Tue, 9 Nov 2010 08:02:17 -0500 Received: from mail-bw0-f46.google.com ([209.85.214.46]:37383 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751165Ab0KINCP convert rfc822-to-8bit (ORCPT ); Tue, 9 Nov 2010 08:02:15 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=OO0hoeofq9sCZ+PGLqRppRQUEVlAgxW3eqb7/RgRc1cHoBDLZv8xuP6k3jxnBUcn0M ooA9z8mA7buZWcdjqXXI0AeLjP9b6sOa0Kyy9/GAe+Rpo/HIeRa2L9JzpLuu7Lfo5g3I svvgWF2/habu3VcxtX8blOYcmVyLRYFn7yt7M= MIME-Version: 1.0 In-Reply-To: <20101109110407.GE2869@n2100.arm.linux.org.uk> References: <1289147348-31969-1-git-send-email-alchark@gmail.com> <1289147348-31969-6-git-send-email-alchark@gmail.com> <20101108041721.GA11605@linux-sh.org> <20101108141407.GA25739@alchark-u3s.lan> <20101108204315.GA12050@linux-sh.org> <20101109103312.GA2869@n2100.arm.linux.org.uk> <20101109105144.GA22389@linux-sh.org> <20101109110407.GE2869@n2100.arm.linux.org.uk> Date: Tue, 9 Nov 2010 14:02:13 +0100 X-Google-Sender-Auth: d5svSVac3F75oKOHTWiiGimSvq8 Message-ID: Subject: Re: [PATCH 6/6 v3] ARM: Add support for the display controllers in VT8500 and WM8505 From: Geert Uytterhoeven To: Russell King - ARM Linux Cc: Paul Mundt , Florian Tobias Schandinat , linux-kernel@vger.kernel.org, Ralf Baechle , Guennadi Liakhovetski , Alexey Charkov , vt8500-wm8505-linux-kernel@googlegroups.com, Andrew Morton , "David S. Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 9, 2010 at 12:04, Russell King - ARM Linux wrote: > On Tue, Nov 09, 2010 at 07:51:45PM +0900, Paul Mundt wrote: >> On Tue, Nov 09, 2010 at 10:33:12AM +0000, Russell King - ARM Linux wrote: >> > On Tue, Nov 09, 2010 at 05:43:16AM +0900, Paul Mundt wrote: >> > > > diff --git a/drivers/video/vt8500lcdfb.c b/drivers/video/vt8500lcdfb.c >> > > > new file mode 100644 >> > > > index 0000000..640d8a3 >> > > > --- /dev/null >> > > > +++ b/drivers/video/vt8500lcdfb.c >> > > > +#include >> > > > + >> > > linux/irq.h is preferred here. >> > >> > I assume you've read the comment at the top of linux/irq.h ? >> >> I had forgotten about that. This comment predates git, so I'm unaware of >> what the context is, could you elaborate on it? > > It's from a time when we didn't have generic irq (and as I understand, > generic irq is still optional.) > > When you didn't have generic irq support for an arch, having drivers > include linux/irq.h resulted in build errors, caused by nothing more > than "use linux/foo.h rather than asm/foo.h" - as those architectures > won't provide an asm/hw_irq.h. > > It looks to me like the only arch in the kernel which doesn't support > generic irq is sh. IIRC, m68k, sparc32, and s390. Gr{oetje,eeting}s,                         Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.                                 -- Linus Torvalds