From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751057AbdAMCyb convert rfc822-to-8bit (ORCPT ); Thu, 12 Jan 2017 21:54:31 -0500 Received: from rtits2.realtek.com ([211.75.126.72]:53198 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750895AbdAMCy3 (ORCPT ); Thu, 12 Jan 2017 21:54:29 -0500 Authenticated-By: X-SpamFilter-By: BOX Solutions SpamTrap 5.56 with qID v0D2rA0j025951, This message is accepted by code: ctloc85258 From: Bard Liao To: Shrirang Bagul , "alsa-devel@alsa-project.org" CC: "linux-kernel@vger.kernel.org" , Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Subject: RE: [PATCH v2 1/4] ASoC: rt5660: Add ACPI support Thread-Topic: [PATCH v2 1/4] ASoC: rt5660: Add ACPI support Thread-Index: AQHSbMuXCMBAyhZck0qRLyVle6fVsqE1srjA Date: Fri, 13 Jan 2017 02:53:10 +0000 Message-ID: References: <20170112120101.16933-1-shrirang.bagul@canonical.com> <20170112120101.16933-2-shrirang.bagul@canonical.com> In-Reply-To: <20170112120101.16933-2-shrirang.bagul@canonical.com> Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.85.221] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Shrirang Bagul [mailto:shrirang.bagul@canonical.com] > Sent: Thursday, January 12, 2017 8:01 PM > To: alsa-devel@alsa-project.org > Cc: linux-kernel@vger.kernel.org; Bard Liao; Oder Chiou; Liam Girdwood; Mark > Brown; Jaroslav Kysela; Takashi Iwai > Subject: [PATCH v2 1/4] ASoC: rt5660: Add ACPI support > > On Dell IoT Gateways, RT5660 codec is available with ACPI ID 10EC3277. > Also, GPIO's are only available by index, so we register mappings to allow > machine drivers to access them by name. > > Signed-off-by: Shrirang Bagul > --- > +static const struct acpi_gpio_params audio_wake_intr_gpio = > { RT5660_GPIO_WAKE_INTR, 0, false }; > +static const struct acpi_gpio_params lineout_mute_gpio = > { RT5660_GPIO_LINEOUT_MUTE, 0, true }; > + > +static const struct acpi_gpio_mapping byt_rt5660_gpios[] = { > + { "audio-wake-intr-gpios", &audio_wake_intr_gpio, 1 }, > + { "lineout-mute-gpios", &lineout_mute_gpio, 1 }, > + { NULL }, > +}; > + I am thinking if it is more suitable to move the gpio params to machine driver? They are not codec's gpios and are only used by machine driver. > -- > 2.9.3