From: Bard Liao <bardliao@realtek.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>,
"broonie@kernel.org" <broonie@kernel.org>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
Oder Chiou <oder_chiou@realtek.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode
Date: Tue, 21 Mar 2017 03:07:25 +0000 [thread overview]
Message-ID: <ABFD875FF5FB574BA706497D987D48D701C4E587@RTITEXTEMP.realtek.com.tw> (raw)
In-Reply-To: <20170320035831.10762-1-kai.heng.feng@canonical.com>
> -----Original Message-----
> From: Kai-Heng Feng [mailto:kai.heng.feng@canonical.com]
> Sent: Monday, March 20, 2017 11:59 AM
> To: broonie@kernel.org
> Cc: lgirdwood@gmail.com; Bard Liao; Oder Chiou;
> alsa-devel@alsa-project.org; linux-kernel@vger.kernel.org; Kai-Heng Feng
> Subject: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS
> 9343 I2S mode
>
> + switch (event) {
> + case SND_SOC_DAPM_PRE_PMD:
> + case SND_SOC_DAPM_POST_PMD:
> + case SND_SOC_DAPM_POST_PMU:
> + snd_soc_write(codec, RT286_SET_AMP_GAIN_HPO,
> AMP_OUT_MUTE);
> + break;
> + case SND_SOC_DAPM_PRE_PMU:
> + snd_soc_write(codec, RT286_SET_AMP_GAIN_HPO,
> AMP_OUT_UNMUTE);
> + break;
Besides Mark's comment, I have question here. It seems you want to mute
HPO before "HP Power" is powered up and after "HP Power" is powered down.
But "HPO L" and "HPO R" are autodisable. And "HP Power" is only connect to
"HPO L" and "HPO R". From my understanding, HPO will mute if "HP Power"
is powered down. Any specific reason for muting HPO again before "HP Power"
is powered up? Will HPO be unmuted before "HP Power" is powered up on your
system? Or should the event be associated with "LDO1"? Which power will
cause the click noise?
next prev parent reply other threads:[~2017-03-21 3:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 3:58 [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode Kai-Heng Feng
2017-03-20 15:08 ` Mark Brown
[not found] ` <CAAd53p53MnZcSEgS47wWcCfm48=J6O3ynjqBdfN6_1nhBMdNwA@mail.gmail.com>
2017-03-20 16:06 ` Mark Brown
2017-03-20 16:23 ` Kai-Heng Feng
2017-03-20 17:26 ` Mark Brown
2017-03-21 5:25 ` Kai-Heng Feng
2017-03-21 9:15 ` Bard Liao
2017-03-22 5:44 ` Kai-Heng Feng
2017-03-21 3:07 ` Bard Liao [this message]
2017-03-21 5:38 ` Kai-Heng Feng
2017-03-21 8:59 ` Bard Liao
2017-03-22 5:37 ` Kai-Heng Feng
2017-03-23 3:29 ` Bard Liao
2017-03-23 4:41 ` Kai-Heng Feng
2017-03-23 6:33 ` Bard Liao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ABFD875FF5FB574BA706497D987D48D701C4E587@RTITEXTEMP.realtek.com.tw \
--to=bardliao@realtek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kai.heng.feng@canonical.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oder_chiou@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).