From: 王文虎 <wenhu.wang@vivo.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Carl Huang <cjhuang@codeaurora.org>,
Thomas Gleixner <tglx@linutronix.de>,
Arnd Bergmann <arnd@arndb.de>,
Nicholas Mc Guire <hofrat@osadl.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@vivo.com
Subject: Re: [PATCH v2] net: qrtr: send msgs from local of same id as broadcast
Date: Tue, 14 Apr 2020 13:14:48 +0800 (GMT+08:00) [thread overview]
Message-ID: <ABYAfQB-CGWquV67Mtd-zKqb.3.1586841288308.Hmail.wenhu.wang@vivo.com> (raw)
In-Reply-To: <20200409193600.GR20625@builder.lan>
From: Bjorn Andersson <bjorn.andersson@linaro.org>
Date: 2020-04-10 03:36:00
To: WANG Wenhu <wenhu.wang@vivo.com>
Cc: "David S. Miller" <davem@davemloft.net>,Jakub Kicinski <kuba@kernel.org>,Carl Huang <cjhuang@codeaurora.org>,
Thomas Gleixner <tglx@linutronix.de>,Arnd Bergmann <arnd@arndb.de>,
Nicholas Mc Guire <hofrat@osadl.org>,netdev@vger.kernel.org,linux-kernel@vger.kernel.org,kernel@vivo.com
Subject: Re: [PATCH v2] net: qrtr: send msgs from local of same id as broadcast>On Tue 07 Apr 20:32 PDT 2020, WANG Wenhu wrote:
>
>> From: Wang Wenhu <wenhu.wang@vivo.com>
>>
>> If the local node id(qrtr_local_nid) is not modified after its
>> initialization, it equals to the broadcast node id(QRTR_NODE_BCAST).
>> So the messages from local node should not be taken as broadcast
>> and keep the process going to send them out anyway.
>>
>> The definitions are as follow:
>> static unsigned int qrtr_local_nid = NUMA_NO_NODE;
>>
>> Fixes: commit fdf5fd397566 ("net: qrtr: Broadcast messages only from control port")
>> Signed-off-by: Wang Wenhu <wenhu.wang@vivo.com>
>> ---
>> Changlog:
>> - For coding style, line up the newline of the if conditional judgement
>> with the one exists before.
>>
>> net/qrtr/qrtr.c | 7 ++++---
>> 1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c
>> index 5a8e42ad1504..545a61f8ef75 100644
>> --- a/net/qrtr/qrtr.c
>> +++ b/net/qrtr/qrtr.c
>> @@ -907,20 +907,21 @@ static int qrtr_sendmsg(struct socket *sock, struct msghdr *msg, size_t len)
>>
>> node = NULL;
>> if (addr->sq_node == QRTR_NODE_BCAST) {
>> - enqueue_fn = qrtr_bcast_enqueue;
>> - if (addr->sq_port != QRTR_PORT_CTRL) {
>> + if (addr->sq_port != QRTR_PORT_CTRL &&
>> + qrtr_local_nid != QRTR_NODE_BCAST) {
>
>So this would mean that if local_nid is configured to be the bcast
>address then rather than rejecting messages to non-control ports we will
>broadcast them.
>
>What happens when some other node in the network replies? Wouldn't it be
>better to explicitly prohibit usage of the bcast address as our node
>address?
>>
>That said, in torvalds/master qrtr_local_nid is no longer initialized to
>QRTR_NODE_BCAST, but 1. So I don't think you need this patch anymore.
>
>Regards,
>Bjorn
>
Hi Bjorn,
You are right. I see the patch that modified the nid to 1 in mainline v5.7-rc1,
and it is better to solve all the problems. As for this patch, the situation is that
I want to use qrtr in kernel to do something else(to develop another driver I name
it RPMON: Remote Processor Monitor), but the ns or service-route functionality
had been missing, so I write another file qsr.c as you had commetted which
did the same thing with ns.c.
The bad thing was I missed the patch from Manivannan.
So, anyway, this patch is not needed anymore.
Thanks,
Wenhu
>> release_sock(sk);
>> return -ENOTCONN;
>> }
>> + enqueue_fn = qrtr_bcast_enqueue;
>> } else if (addr->sq_node == ipc->us.sq_node) {
>> enqueue_fn = qrtr_local_enqueue;
>> } else {
>> - enqueue_fn = qrtr_node_enqueue;
>> node = qrtr_node_lookup(addr->sq_node);
>> if (!node) {
>> release_sock(sk);
>> return -ECONNRESET;
>> }
>> + enqueue_fn = qrtr_node_enqueue;
>> }
>>
>> plen = (len + 3) & ~3;
>> --
>> 2.17.1
>>
prev parent reply other threads:[~2020-04-14 5:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 13:29 [PATCH] net: qrtr: send msgs from local of same id as broadcast WANG Wenhu
2020-04-08 1:38 ` David Miller
2020-04-08 3:32 ` [PATCH v2] " WANG Wenhu
2020-04-08 19:56 ` David Miller
2020-04-09 19:36 ` Bjorn Andersson
2020-04-14 5:14 ` 王文虎 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ABYAfQB-CGWquV67Mtd-zKqb.3.1586841288308.Hmail.wenhu.wang@vivo.com \
--to=wenhu.wang@vivo.com \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=cjhuang@codeaurora.org \
--cc=davem@davemloft.net \
--cc=hofrat@osadl.org \
--cc=kernel@vivo.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).