From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 932A4C4363D for ; Wed, 23 Sep 2020 14:46:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6265A206FB for ; Wed, 23 Sep 2020 14:46:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726763AbgIWOqd convert rfc822-to-8bit (ORCPT ); Wed, 23 Sep 2020 10:46:33 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:52072 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726332AbgIWOqc (ORCPT ); Wed, 23 Sep 2020 10:46:32 -0400 Received: from mail-pj1-f71.google.com ([209.85.216.71]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kL62Q-0008L9-Jf for linux-kernel@vger.kernel.org; Wed, 23 Sep 2020 14:46:30 +0000 Received: by mail-pj1-f71.google.com with SMTP id fs5so39804pjb.7 for ; Wed, 23 Sep 2020 07:46:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=IRV4DsqTHJS4UCf0ZaCBRMDHJJpdRDGlcpY0NuGhQ7g=; b=AkbKEDDSjwUcE23MQAc6VPS15cwVw9S/tEb6ok/lG54rvz3cyAYCSZJzXcvdDyvTRs Na2wR9CAnY1ObHUA40XLMOCwoXDhCoiRyHkfnlbap9SFKtpESPert1478k/c+EkGqquG A/RqZWjP81uld5+WJ/KYpVdvh1QnS5gOZq6Pk7mKAU8ZKFUIhg+DlEERUa6Bp69ceBTq udocavL2TBG3I+bPm3Ee5DIygvbGlSOC23SAlzv2W2tIsfpjR50katMYFqE7bqBN6y1/ YzL3HGts16yMxYKd/1Z13Ot4zB5SboFbrqZKmXGVLd/I9Kp9WBWt3k1fOZtcOrfPnWUV fbKQ== X-Gm-Message-State: AOAM53007o1l7jfZYgRgBAi8LEUS4wRTN9Q2bzW9yoFxdNIGEU1mMupO UCiBh7GDHw7GQb6LqUItlzkf0OIGXiz9lAb6kRa/2n71S/a2drfBip+SS3qkFgvf8kUdUsXOqAN w/xS7dFmPBBtJYxGPtAN5mwHJdEPpKiKeLNb6X9ah5w== X-Received: by 2002:a63:7d5a:: with SMTP id m26mr66984pgn.373.1600872389148; Wed, 23 Sep 2020 07:46:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzEca3T4aPQaV9RL6AocGE0yU0atcnRNqviEk4KyxvvK1PiNJGTRuAf0er4y9Q9pep6pePjdg== X-Received: by 2002:a63:7d5a:: with SMTP id m26mr66963pgn.373.1600872388857; Wed, 23 Sep 2020 07:46:28 -0700 (PDT) Received: from [192.168.1.208] (220-133-187-190.HINET-IP.hinet.net. [220.133.187.190]) by smtp.gmail.com with ESMTPSA id t10sm217313pgp.15.2020.09.23.07.46.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Sep 2020 07:46:28 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\)) Subject: Re: [Intel-wired-lan] [PATCH] e1000e: Power cycle phy on PM resume From: Kai-Heng Feng In-Reply-To: <17092088-86ff-2d31-b3de-2469419136a3@molgen.mpg.de> Date: Wed, 23 Sep 2020 22:46:25 +0800 Cc: Jeff Kirsher , "open list:NETWORKING DRIVERS" , open list , "moderated list:INTEL ETHERNET DRIVERS" , Jakub Kicinski , "David S. Miller" Content-Transfer-Encoding: 8BIT Message-Id: References: <20200923074751.10527-1-kai.heng.feng@canonical.com> <17092088-86ff-2d31-b3de-2469419136a3@molgen.mpg.de> To: Paul Menzel X-Mailer: Apple Mail (2.3608.120.23.2.1) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, > On Sep 23, 2020, at 21:28, Paul Menzel wrote: > > Dear Kai-Heng, > > > Am 23.09.20 um 09:47 schrieb Kai-Heng Feng: >> We are seeing the following error after S3 resume: >> [ 704.746874] e1000e 0000:00:1f.6 eno1: Setting page 0x6020 >> [ 704.844232] e1000e 0000:00:1f.6 eno1: MDI Write did not complete >> [ 704.902817] e1000e 0000:00:1f.6 eno1: Setting page 0x6020 >> [ 704.903075] e1000e 0000:00:1f.6 eno1: reading PHY page 769 (or 0x6020 shifted) reg 0x17 >> [ 704.903281] e1000e 0000:00:1f.6 eno1: Setting page 0x6020 >> [ 704.903486] e1000e 0000:00:1f.6 eno1: writing PHY page 769 (or 0x6020 shifted) reg 0x17 >> [ 704.943155] e1000e 0000:00:1f.6 eno1: MDI Error >> ... >> [ 705.108161] e1000e 0000:00:1f.6 eno1: Hardware Error >> Since we don't know what platform firmware may do to the phy, so let's >> power cycle the phy upon system resume to resolve the issue. > > Is there a bug report or list thread for this issue? No. That's why I sent a patch to start discussion :) > >> Signed-off-by: Kai-Heng Feng >> --- >> drivers/net/ethernet/intel/e1000e/netdev.c | 2 ++ >> 1 file changed, 2 insertions(+) >> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c >> index 664e8ccc88d2..c2a87a408102 100644 >> --- a/drivers/net/ethernet/intel/e1000e/netdev.c >> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c >> @@ -6968,6 +6968,8 @@ static __maybe_unused int e1000e_pm_resume(struct device *dev) >> !e1000e_check_me(hw->adapter->pdev->device)) >> e1000e_s0ix_exit_flow(adapter); >> + e1000_power_down_phy(adapter); >> + >> rc = __e1000_resume(pdev); >> if (rc) >> return rc; > > How much does this increase the resume time? I didn't measure it. Because for me it's more important to have a working device. Does it have a noticeable impact on your system's resume time? Kai-Heng > > > Kind regards, > > Paul >