From: Zi Yan <ziy@nvidia.com>
To: Huang Ying <ying.huang@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Yang Shi <yang.shi@linux.alibaba.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
osalvador <osalvador@suse.de>, Yang Shi <shy828301@gmail.com>,
Michal Hocko <mhocko@suse.com>, Wei Xu <weixugc@google.com>,
Dan Williams <dan.j.williams@intel.com>,
David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH -V10 3/9] mm/migrate: enable returning precise migrate_pages() success count
Date: Thu, 15 Jul 2021 14:02:48 -0400 [thread overview]
Message-ID: <ACF5FE3A-FD50-4BFF-899D-B1AA3B02F83F@nvidia.com> (raw)
In-Reply-To: <20210715055145.195411-4-ying.huang@intel.com>
[-- Attachment #1: Type: text/plain, Size: 2176 bytes --]
On 15 Jul 2021, at 1:51, Huang Ying wrote:
> From: Yang Shi <yang.shi@linux.alibaba.com>
>
> Under normal circumstances, migrate_pages() returns the number of
> pages migrated. In error conditions, it returns an error code. When
> returning an error code, there is no way to know how many pages were
> migrated or not migrated.
>
> Make migrate_pages() return how many pages are demoted successfully
> for all cases, including when encountering errors. Page reclaim
> behavior will depend on this in subsequent patches.
>
> Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
> Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
> Suggested-by: osalvador <osalvador@suse.de> [optional parameter]
> Reviewed-by: Yang Shi <shy828301@gmail.com>
> Cc: Michal Hocko <mhocko@suse.com>
> Cc: Wei Xu <weixugc@google.com>
> Cc: Zi Yan <ziy@nvidia.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: David Hildenbrand <david@redhat.com>
>
> --
>
> Note: Yang Shi originally wrote the patch, thus the SoB. There was
> also a Reviewed-by provided since there were some modifications made
> to this after the original work.
>
> Changes since 20210618:
> * Reword some bits of the changelog/subject
> * Allow callers to pass a NULL 'ret_succeeded'. This ensures that
> callers don't have to declare and pass a dummy variable.
>
> Changes since 20210302:
> * Fix definition of CONFIG_MIGRATION=n stub migrate_pages(). Its
> parameters were wrong, but oddly enough did not generate any
> compile errors.
>
> Changes since 20200122:
> * Fix migrate_pages() to manipulate nr_succeeded *value*
> rather than the pointer.
> ---
> include/linux/migrate.h | 5 +++--
> mm/compaction.c | 2 +-
> mm/gup.c | 2 +-
> mm/memory-failure.c | 2 +-
> mm/memory_hotplug.c | 2 +-
> mm/mempolicy.c | 4 ++--
> mm/migrate.c | 11 ++++++++---
> mm/page_alloc.c | 2 +-
> 8 files changed, 18 insertions(+), 12 deletions(-)
>
LGTM. Reviewed-by: Zi Yan <ziy@nvidia.com>
—
Best Regards,
Yan, Zi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 854 bytes --]
next prev parent reply other threads:[~2021-07-15 18:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 5:51 [PATCH -V10 0/9] Migrate Pages in lieu of discard Huang Ying
2021-07-15 5:51 ` [PATCH -V10 1/9] mm/numa: automatically generate node migration order Huang Ying
2021-07-15 17:52 ` Zi Yan
2021-07-15 5:51 ` [PATCH -V10 2/9] mm/migrate: update node demotion order on hotplug events Huang Ying
2021-07-15 18:00 ` Zi Yan
2021-07-15 5:51 ` [PATCH -V10 3/9] mm/migrate: enable returning precise migrate_pages() success count Huang Ying
2021-07-15 18:02 ` Zi Yan [this message]
2021-07-15 5:51 ` [PATCH -V10 4/9] mm/migrate: demote pages during reclaim Huang Ying
2021-07-15 5:51 ` [PATCH -V10 5/9] mm/vmscan: add page demotion counter Huang Ying
2021-07-15 5:51 ` [PATCH -V10 6/9] mm/vmscan: add helper for querying ability to age anonymous pages Huang Ying
2021-07-15 5:51 ` [PATCH -V10 7/9] mm/vmscan: Consider anonymous pages without swap Huang Ying
2021-07-15 5:51 ` [PATCH -V10 8/9] mm/vmscan: never demote for memcg reclaim Huang Ying
2021-07-15 5:51 ` [PATCH -V10 9/9] mm/migrate: add sysfs interface to enable reclaim migration Huang Ying
2021-07-15 19:38 ` [PATCH -V10 0/9] Migrate Pages in lieu of discard Andrew Morton
2021-07-15 21:42 ` Dave Hansen
2021-07-16 1:10 ` Matthew Wilcox
2021-07-16 3:32 ` Huang, Ying
2021-07-16 3:54 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ACF5FE3A-FD50-4BFF-899D-B1AA3B02F83F@nvidia.com \
--to=ziy@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=shy828301@gmail.com \
--cc=weixugc@google.com \
--cc=yang.shi@linux.alibaba.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).