linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: 王擎 <wangqing@vivo.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Felipe Balbi <balbi@kernel.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re:Re: [PATCH] usb: Assign NULL ​​to phy that may be returned
Date: Fri, 6 Nov 2020 15:39:40 +0800 (GMT+08:00)	[thread overview]
Message-ID: <ACIArQBlDXHfZNI0kyjfGqo0.3.1604648380903.Hmail.wangqing@vivo.com> (raw)
In-Reply-To: <20201106065131.GD697514@kroah.com>

>> Assign initial values to local variables that may be returned
>> 
>> Signed-off-by: Wang Qing <wangqing@vivo.com>
>
>Your subject, and body of text, seem to have 2 "odd" characters in it,
>please fix up.
>
>Also, your subject and changelog body here are identical, please be much
>more verbose in the body explaining why you are doing something, not
>just what you are doing.
>
>And your subject line should also match other patches for this file, and
>have "usb: phy: ..." in the beginning.
Yeah, I got it.
>
>> ---
>>  drivers/usb/phy/phy.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c
>> index b47285f..de21967
>> --- a/drivers/usb/phy/phy.c
>> +++ b/drivers/usb/phy/phy.c
>> @@ -59,7 +59,7 @@ static struct usb_phy *__usb_find_phy(struct list_head *list,
>>  
>>  static struct usb_phy *__of_usb_find_phy(struct device_node *node)
>>  {
>> -	struct usb_phy  *phy;
>> +	struct usb_phy  *phy = NULL;
>
>Why isn't the compiler complaining about this today?  Are you sure this
>is needed?
Sorry, I didn't look at it carefully, because __usb_find_phy has an initial value, 
and I was affected.. You don't need to modify it, In fact.

thanks,

Wang Qing
>
>thanks,
>
>greg k-h



      reply	other threads:[~2020-11-06  7:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-06  3:15 [PATCH] usb: Assign NULL ​​to phy that may be returned Wang Qing
2020-11-06  6:51 ` Greg Kroah-Hartman
2020-11-06  7:39   ` 王擎 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ACIArQBlDXHfZNI0kyjfGqo0.3.1604648380903.Hmail.wangqing@vivo.com \
    --to=wangqing@vivo.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).