From: 王擎 <wangqing@vivo.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>, Mike Galbraith <efault@gmx.de>,
Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re:Re: [PATCH] sched: swait: use wake_up_process() instead of wake_up_state()
Date: Thu, 18 Mar 2021 10:14:18 +0800 (GMT+08:00) [thread overview]
Message-ID: <AD2AAwDtDgN4Fh3ZMJ2Tcap5.3.1616033658963.Hmail.wangqing@vivo.com> (raw)
In-Reply-To: <YFHbdojO5TtztzEn@hirez.programming.kicks-ass.net>
>>
>> * Mike Galbraith <efault@gmx.de> wrote:
>>
>> > On Tue, 2021-03-16 at 19:20 +0800, Wang Qing wrote:
>> > > Why not just use wake_up_process().
>> >
>> > IMO this is not an improvement. There are other places where explicit
>> > TASK_NORMAL is used as well, and they're all perfectly clear as is.
>>
>> Arguably those could all be converted to wake_up_process() as well.
>> It's a very small kernel code size optimization. There's about 3 such
>> places, could be converted in a single patch.
>
>It's still pointless churn IMO.
Using wake_up_process() is more simpler and friendly for beginners,
and it is more convenient for analysis and statistics.
next prev parent reply other threads:[~2021-03-18 2:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 11:20 [PATCH] sched: swait: use wake_up_process() instead of wake_up_state() Wang Qing
2021-03-17 4:43 ` Mike Galbraith
2021-03-17 9:46 ` Ingo Molnar
2021-03-17 10:35 ` Peter Zijlstra
2021-03-18 2:14 ` 王擎 [this message]
2021-03-18 3:03 ` Mike Galbraith
2021-03-17 10:41 ` Mike Galbraith
2021-03-17 14:57 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AD2AAwDtDgN4Fh3ZMJ2Tcap5.3.1616033658963.Hmail.wangqing@vivo.com \
--to=wangqing@vivo.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=efault@gmx.de \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).