From: <Kento.A.Kobayashi@sony.com>
To: <oneukum@suse.com>, <gregkh@linuxfoundation.org>,
<stern@rowland.harvard.edu>
Cc: <usb-storage@lists.one-eyed-alien.net>, <Jacky.Cao@sony.com>,
<linux-kernel@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
<linux-usb@vger.kernel.org>, <Kento.A.Kobayashi@sony.com>
Subject: RE: [PATCH] usb: uas: fix usb subsystem hang after power off hub port
Date: Thu, 28 Mar 2019 07:53:14 +0000 [thread overview]
Message-ID: <AE5419EAB4965843B3C0C1FE29F1FFE588FCC9@JPYOKXMS103.jp.sony.com> (raw)
In-Reply-To: <1553510086.2668.2.camel@suse.com>
Hi,
>Sorry,
>
>I thought this was clear. Your patch is making the assumption that the reset is triggered by the SCSI layer. You cannot make that assumption, as there is an ioctl for resetting a USB device.
>In case we are getting an error during the reset (our endpoints vanish), the device driver must report that to the USB layer, so the driver will always be disconnected.
>We cannot drop errors.
>
> Regards
> Oliver
This patch modified uas_post_reset to skip rebind operation to avoid exception while -ENODEV happens not drop error.
If uas_post_reset happens -ENODEV, usb_reset_and_verify_device must happen error.
So,when we use ioctl(USBDEVFS_RESET) to reset device, if usb_reset_and_verify_device happens error, the error will be reported through ioctl return value.
Regards,
Kento Kobayashi
next prev parent reply other threads:[~2019-03-28 7:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 9:13 [PATCH] usb: uas: fix usb subsystem hang after power off hub port Kento.A.Kobayashi
2019-03-08 16:52 ` Oliver Neukum
2019-03-08 17:33 ` Alan Stern
2019-03-11 8:36 ` Kento.A.Kobayashi
2019-03-12 15:37 ` Oliver Neukum
2019-03-15 2:28 ` Kento.A.Kobayashi
2019-03-25 10:21 ` Kento.A.Kobayashi
2019-03-25 10:34 ` Oliver Neukum
2019-03-28 7:53 ` Kento.A.Kobayashi [this message]
2019-03-28 15:15 ` Oliver Neukum
2019-03-28 15:57 ` Alan Stern
2019-03-28 16:49 ` Oliver Neukum
2019-03-29 14:13 ` Alan Stern
2019-04-02 0:28 ` Kento.A.Kobayashi
2019-04-02 14:38 ` Alan Stern
2019-04-04 3:57 ` Kento.A.Kobayashi
2019-04-04 19:33 ` Alan Stern
2019-04-09 0:28 ` Kento.A.Kobayashi
2019-04-09 1:21 ` Alan Stern
2019-04-09 2:10 ` Martin K. Petersen
2019-04-09 14:44 ` Alan Stern
2019-04-09 15:16 ` Bart Van Assche
2019-04-09 16:45 ` Alan Stern
2019-04-15 0:27 ` Kento.A.Kobayashi
2019-04-15 15:18 ` Alan Stern
2019-04-15 15:32 ` Alan Stern
2019-04-16 2:31 ` Kento.A.Kobayashi
2019-04-10 2:11 ` Martin K. Petersen
[not found] <16EA1F625E922C43B00B9D8225022050086961B5@APYOKXMS108.ap.sony.com>
2019-03-04 6:23 ` Greg KH
2019-03-04 7:19 ` Jacky.Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AE5419EAB4965843B3C0C1FE29F1FFE588FCC9@JPYOKXMS103.jp.sony.com \
--to=kento.a.kobayashi@sony.com \
--cc=Jacky.Cao@sony.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).