From: "Ong, Boon Leong" <boon.leong.ong@intel.com>
To: Andrew Lunn <andrew@lunn.ch>, "Voon, Weifeng" <weifeng.voon@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Kweh, Hock Leong" <hock.leong.kweh@intel.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Jose Abreu <joabreu@synopsys.com>
Subject: RE: [PATCH 0/7] net: stmmac: enable EHL SGMII
Date: Thu, 25 Apr 2019 14:39:06 +0000 [thread overview]
Message-ID: <AF233D1473C1364ABD51D28909A1B1B75C0B205D@pgsmsx114.gar.corp.intel.com> (raw)
In-Reply-To: <20190425123801.GD8117@lunn.ch>
>-----Original Message-----
>From: Andrew Lunn [mailto:andrew@lunn.ch]
>Sent: Thursday, April 25, 2019 8:38 PM
>To: Voon, Weifeng <weifeng.voon@intel.com>
>Cc: David S. Miller <davem@davemloft.net>; netdev@vger.kernel.org; linux-
>kernel@vger.kernel.org; Ong, Boon Leong <boon.leong.ong@intel.com>;
>Kweh, Hock Leong <hock.leong.kweh@intel.com>; Florian Fainelli
><f.fainelli@gmail.com>; Maxime Coquelin <mcoquelin.stm32@gmail.com>;
>Giuseppe Cavallaro <peppe.cavallaro@st.com>; Jose Abreu
><joabreu@synopsys.com>
>Subject: Re: [PATCH 0/7] net: stmmac: enable EHL SGMII
>
>On Thu, Apr 25, 2019 at 07:27:51AM +0000, Voon, Weifeng wrote:
>> > > This patch-set is to enable Ethernet controller (DW Ethernet QoS and
>> > > DW Ethernet PCS) with SGMII interface in Elkhart Lake.
>> >
>> > Can the hardware also do 1000BaseX?
>>
>> Yes, it is able to do 1000BaseX.
>
>I Voon
>
>That means you should not really hard code it to SGMII. Somebody is
>going to connect an SFP or an Ethernet switch and want to use
>1000BaseX.
Hi Andrew,
The Ethernet controller consists of two ways to connect to external PHY,
RGMII and SGMII. The selection is done through soft strap.
The patch-series is to enable SGMII interface. The DW xPCS IP is
configured to operate in 1000BASE-X mode. The xPCS IP is external
connected through internal PHY interface which presents externally
as SGMII interface. To help illustrate the connection:-
<-----------------GBE Controller----------------->|<--External PHY chip-->
+----------+ +----+ +---+ +-----------------+
| EQoS | <-GMII->|xPCS|<--> | L1 | <-- SGMII --> | External GbE |
| MAC | | | |PHY| | PHY Chip |
+----------+ +----+ +---+ +-----------------+
In future, we will submit the changes for the RGMII connection that
bypasses DW xPCS.
Hope this help clarifies matter.
>At minimum, please add support for phy-mode in the device tree.
>
>Also, when the adjust_link callback passed to phy_connect() is called,
>you can look at the interface type to know if you need to configure it
>to SGMII or 1000BaseX. A copper PHY in an SFP module generally wants
>SGMII, but an optical module wants 1000BaseX. But to properly support
>SPFs the driver needs to swap to phylink, rather than phylib.
>
> Andrew
next prev parent reply other threads:[~2019-04-25 14:39 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 17:17 [PATCH 0/7] net: stmmac: enable EHL SGMII Weifeng Voon
2019-04-24 9:26 ` Jose Abreu
2019-04-24 13:48 ` Andrew Lunn
2019-04-25 7:27 ` Voon, Weifeng
2019-04-25 12:38 ` Andrew Lunn
2019-04-25 14:39 ` Ong, Boon Leong [this message]
2019-04-25 15:23 ` Andrew Lunn
2019-04-29 5:37 ` Ong, Boon Leong
2019-04-29 13:10 ` Andrew Lunn
2019-04-29 13:44 ` Jose Abreu
2019-04-24 17:17 ` [PATCH 1/7] net: stmmac: add EHL SGMII 1Gbps platform data and PCI ID Weifeng Voon
2019-04-25 7:04 ` Voon, Weifeng
2019-04-25 12:24 ` Andrew Lunn
2019-04-26 2:10 ` Voon, Weifeng
2019-04-24 17:17 ` [PATCH 2/7] net: stmmac: enable clause 45 mdio support Weifeng Voon
2019-04-24 13:18 ` Andrew Lunn
2019-04-25 7:12 ` Voon, Weifeng
2019-04-24 17:17 ` [PATCH 3/7] net: stmmac: dma channel control register need to be init first Weifeng Voon
2019-04-25 7:06 ` Voon, Weifeng
2019-04-29 10:25 ` Jose Abreu
2019-04-30 2:49 ` Voon, Weifeng
2019-04-24 17:17 ` [PATCH 4/7] net: stmmac: introducing support for DWC xPCS logics Weifeng Voon
2019-04-24 13:41 ` Andrew Lunn
2019-04-25 1:45 ` Ong, Boon Leong
2019-04-25 3:21 ` Andrew Lunn
2019-04-25 6:51 ` Ong, Boon Leong
2019-04-25 12:22 ` Andrew Lunn
2019-04-25 7:06 ` Voon, Weifeng
2019-04-29 13:23 ` Jose Abreu
2019-04-24 17:17 ` [PATCH 5/7] net: stmmac: add xpcs function hooks into main driver and ethtool Weifeng Voon
2019-04-25 7:07 ` Voon, Weifeng
2019-04-24 17:17 ` [PATCH 6/7] net: stmmac: add xPCS platform data for EHL Weifeng Voon
2019-04-25 7:08 ` Voon, Weifeng
2019-04-24 17:17 ` [PATCH 7/7] net: stmmac: add xPCS functions for device with DWMACv5.1 Weifeng Voon
2019-04-25 7:09 ` Voon, Weifeng
2019-04-25 7:00 ` [PATCH 0/7] net: stmmac: enable EHL SGMII Voon, Weifeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AF233D1473C1364ABD51D28909A1B1B75C0B205D@pgsmsx114.gar.corp.intel.com \
--to=boon.leong.ong@intel.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hock.leong.kweh@intel.com \
--cc=joabreu@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=weifeng.voon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).