From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7F60C10F14 for ; Tue, 23 Apr 2019 14:13:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 825F9214AE for ; Tue, 23 Apr 2019 14:13:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728073AbfDWONJ convert rfc822-to-8bit (ORCPT ); Tue, 23 Apr 2019 10:13:09 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:38978 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727829AbfDWONI (ORCPT ); Tue, 23 Apr 2019 10:13:08 -0400 Received: from dggemi403-hub.china.huawei.com (unknown [172.30.72.55]) by Forcepoint Email with ESMTP id 15B3B1ADEC81549BCE04; Tue, 23 Apr 2019 22:13:05 +0800 (CST) Received: from DGGEMI530-MBX.china.huawei.com ([169.254.7.146]) by dggemi403-hub.china.huawei.com ([10.3.17.136]) with mapi id 14.03.0415.000; Tue, 23 Apr 2019 22:13:00 +0800 From: weizhenliang To: Oleg Nesterov CC: "ebiederm@xmission.com" , "colona@arista.com" , "akpm@linux-foundation.org" , "christian@brauner.io" , "arnd@arndb.de" , "tglx@linutronix.de" , "deepa.kernel@gmail.com" , "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: Re: [PATCH v3] signal: trace_signal_deliver when signal_group_exit Thread-Topic: [PATCH v3] signal: trace_signal_deliver when signal_group_exit Thread-Index: AdT53MSZ+tEkhqd4QUap/zXK56zV+Q== Date: Tue, 23 Apr 2019 14:13:00 +0000 Message-ID: Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.40.99.192] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/23, Oleg wrote: >On 04/23, weizhenliang wrote: >> >> Last time Oleg suggested using SIG_DFL as the third parameter, but its type is 'void (*)(int)', but not expected 'struct k_sigaction *'. > >Yes I misread the signature of TRACE_EVENT(signal_deliver), and I thought you at least compiled the kernel with your patch applied ;) > >> How about >> trace_signal_deliver(SIGKILL, SEND_SIG_NOINFO, &sighand->action[signr >> - 1]); ? > >sure, this should fix the problem. Sorry about that, I will pay more attention to it in the future. And thanks for your reply, I will re-adjust the patch later. Wei.