From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933534AbcFNCmU (ORCPT ); Mon, 13 Jun 2016 22:42:20 -0400 Received: from mail.kmu-office.ch ([178.209.48.109]:55321 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932797AbcFNCmS (ORCPT ); Mon, 13 Jun 2016 22:42:18 -0400 User-Agent: K-9 Mail for Android In-Reply-To: References: <20160609151039.20817-1-bhuvanchandra.dv@toradex.com> <20160609151039.20817-3-bhuvanchandra.dv@toradex.com> <20160611140341.GT20243@tiger> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH 2/8] tty: serial: fsl_lpuart: support suspend/resume From: Stefan Agner Date: Mon, 13 Jun 2016 19:42:10 -0700 To: Bhhuvanchandra DV , Shawn Guo CC: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org, mturquette@baylibre.com, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, jslaby@suse.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Message-ID: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On June 13, 2016 5:18:19 PM PDT, Bhhuvanchandra DV wrote: >Hi Shawn, > >On 06/11/2016 02:03 PM, Shawn Guo wrote: > >> On Thu, Jun 09, 2016 at 08:40:33PM +0530, Bhuvanchandra DV wrote: >>> From: Stefan Agner >>> >>> In order to allow wake support in STOP sleep mode, clocks are >>> needed. Use imx_clk_gate2_cgr to disable automatic clock gating >>> in low power mode STOP. This allows to enable wake by UART using: >>> echo enabled > /sys/class/tty/ttyLP0/power/wakeup >>> >>> However, if wake is not enabled, the driver should disable the >>> clocks explicitly to save power. >>> >>> Signed-off-by: Stefan Agner >>> --- >>> drivers/clk/imx/clk-vf610.c | 12 ++++++------ >> Please send clock driver changes in a separate patch. The changes are dependet on each other, hence I put it in a single patch. But since it is a new feature it shouldn't really matter... > >How about splitting this patchset to two? few patches are having minor >fixes and the few patches might need some review and discussions. >May be some thing like DMA fixes and the other minor fixes. I don't think that splitting up the patchset is necessary, with the current order it is possible to pick up the fixes independently... -- Stefan > >-- >Bhuvan > >> >> Shawn >> >>> drivers/tty/serial/fsl_lpuart.c | 16 ++++++++++++++-- >>> 2 files changed, 20 insertions(+), 8 deletions(-) -- Sent from my Android device with K-9 Mail. Please excuse my brevity.