From: Aisheng Dong <aisheng.dong@nxp.com>
To: Anson Huang <anson.huang@nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"wsa+renesas@sang-engineering.com"
<wsa+renesas@sang-engineering.com>,
"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
"eha@deif.com" <eha@deif.com>,
"linux@rempel-privat.de" <linux@rempel-privat.de>,
"mojha@codeaurora.org" <mojha@codeaurora.org>,
Laurentiu Tudor <laurentiu.tudor@nxp.com>,
"peda@axentia.se" <peda@axentia.se>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH] i2c: imx: correct the method of getting private data in notifier_call
Date: Wed, 17 Apr 2019 03:17:10 +0000 [thread overview]
Message-ID: <AM0PR04MB42110D893D07DFECFE167F5580250@AM0PR04MB4211.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <AM0PR04MB4211D493C95357CE7B69574A80250@AM0PR04MB4211.eurprd04.prod.outlook.com>
[...]
> >
> > Fixes: 90ad2cbe88c2("i2c: imx: use clk notifier for rate changes")
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
>
> Please also provide how to reproduce it.
> And it seems not a new issue, should we CC stable?
Besides above comments:
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
Regards
Dong Aisheng
>
> Regards
> Dong Aisheng
>
> > ---
> > drivers/i2c/busses/i2c-imx.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-imx.c
> > b/drivers/i2c/busses/i2c-imx.c index
> > c0c3043..fd70b11 100644
> > --- a/drivers/i2c/busses/i2c-imx.c
> > +++ b/drivers/i2c/busses/i2c-imx.c
> > @@ -515,9 +515,9 @@ static int i2c_imx_clk_notifier_call(struct
> > notifier_block *nb,
> > unsigned long action, void *data) {
> > struct clk_notifier_data *ndata = data;
> > - struct imx_i2c_struct *i2c_imx = container_of(&ndata->clk,
> > + struct imx_i2c_struct *i2c_imx = container_of(nb,
> > struct imx_i2c_struct,
> > - clk);
> > + clk_change_nb);
> >
> > if (action & POST_RATE_CHANGE)
> > i2c_imx_set_clk(i2c_imx, ndata->new_rate);
> > --
> > 2.7.4
next prev parent reply other threads:[~2019-04-17 3:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 1:59 [PATCH] i2c: imx: correct the method of getting private data in notifier_call Anson Huang
2019-04-17 3:13 ` Aisheng Dong
2019-04-17 3:17 ` Aisheng Dong [this message]
2019-04-23 21:22 ` Wolfram Sang
2019-04-17 3:18 ` Anson Huang
2019-04-23 21:21 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR04MB42110D893D07DFECFE167F5580250@AM0PR04MB4211.eurprd04.prod.outlook.com \
--to=aisheng.dong@nxp.com \
--cc=anson.huang@nxp.com \
--cc=eha@deif.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=mojha@codeaurora.org \
--cc=peda@axentia.se \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).